aboutsummaryrefslogtreecommitdiff
path: root/FORK.md
diff options
context:
space:
mode:
authorIgor Soarez <igor@soarez.org>2026-08-29 22:59:29 +0100
committerIgor Soarez <igor@soarez.org>2026-10-14 12:19:26 +0100
commitcfa0b6f854e7f15717db385df0e43f974a4b1e67 (patch)
tree661c6aa9f5168c74f28a8c694a73381a2d9d0d25 /FORK.md
parent681ea9d0b3b89bec1ad8c57ef79ae2d4d82ef49b (diff)
fix(setup): skip local-browser precondition for every remote target
The pre-flight check only skipped isBrowserRunning() when BU_CDP_HTTP was set, so a machine with no local browser failed /browser-setup with 'No browser instance running' before discovery ever dialed the built-in castle default. Resolve the target the same way discovery does and skip the local-process check whenever it resolves remote — env var, /browser-target choice, or default. A resolved local target still requires a local browser, and an unreachable remote still fails loudly in step 4.
Diffstat (limited to 'FORK.md')
-rw-r--r--FORK.md6
1 files changed, 6 insertions, 0 deletions
diff --git a/FORK.md b/FORK.md
index c273980..853b812 100644
--- a/FORK.md
+++ b/FORK.md
@@ -104,6 +104,12 @@ git push --force-with-lease origin master
Conflicts to expect are confined to `src/cdp/discovery.ts` (the
`discoverEndpoint()` short-circuit and the `host` parameter on
`queryLiveWsUrl`) and `src/setup.ts` (the skipped local-process precondition).
+
+The setup precondition skips `isBrowserRunning()` whenever the resolved target
+is remote — by env var, `/browser-target` choice, or the built-in default — not
+merely when `BU_CDP_HTTP` is set. A machine with no local browser (any host
+relying on the castle default) would otherwise fail `/browser-setup` with "No
+browser instance running" before discovery ever dialed the remote.
If upstream ever reworks daemon discovery, re-check whether the patch is still
needed at all.