From cfa0b6f854e7f15717db385df0e43f974a4b1e67 Mon Sep 17 00:00:00 2001 From: Igor Soarez Date: Sat, 29 Aug 2026 22:59:29 +0100 Subject: fix(setup): skip local-browser precondition for every remote target MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The pre-flight check only skipped isBrowserRunning() when BU_CDP_HTTP was set, so a machine with no local browser failed /browser-setup with 'No browser instance running' before discovery ever dialed the built-in castle default. Resolve the target the same way discovery does and skip the local-process check whenever it resolves remote — env var, /browser-target choice, or default. A resolved local target still requires a local browser, and an unreachable remote still fails loudly in step 4. --- FORK.md | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'FORK.md') diff --git a/FORK.md b/FORK.md index c273980..853b812 100644 --- a/FORK.md +++ b/FORK.md @@ -104,6 +104,12 @@ git push --force-with-lease origin master Conflicts to expect are confined to `src/cdp/discovery.ts` (the `discoverEndpoint()` short-circuit and the `host` parameter on `queryLiveWsUrl`) and `src/setup.ts` (the skipped local-process precondition). + +The setup precondition skips `isBrowserRunning()` whenever the resolved target +is remote — by env var, `/browser-target` choice, or the built-in default — not +merely when `BU_CDP_HTTP` is set. A machine with no local browser (any host +relying on the castle default) would otherwise fail `/browser-setup` with "No +browser instance running" before discovery ever dialed the remote. If upstream ever reworks daemon discovery, re-check whether the patch is still needed at all. -- cgit v1.2.3