aboutsummaryrefslogtreecommitdiff
path: root/FORK.md
diff options
context:
space:
mode:
Diffstat (limited to 'FORK.md')
-rw-r--r--FORK.md6
1 files changed, 6 insertions, 0 deletions
diff --git a/FORK.md b/FORK.md
index c273980..853b812 100644
--- a/FORK.md
+++ b/FORK.md
@@ -104,6 +104,12 @@ git push --force-with-lease origin master
Conflicts to expect are confined to `src/cdp/discovery.ts` (the
`discoverEndpoint()` short-circuit and the `host` parameter on
`queryLiveWsUrl`) and `src/setup.ts` (the skipped local-process precondition).
+
+The setup precondition skips `isBrowserRunning()` whenever the resolved target
+is remote — by env var, `/browser-target` choice, or the built-in default — not
+merely when `BU_CDP_HTTP` is set. A machine with no local browser (any host
+relying on the castle default) would otherwise fail `/browser-setup` with "No
+browser instance running" before discovery ever dialed the remote.
If upstream ever reworks daemon discovery, re-check whether the patch is still
needed at all.