1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
use serde::{Deserialize, Serialize};
pub(crate) const DEFAULT_TAB_BAR_COMMAND_INTERVAL_SECONDS: u64 = 5;
pub(crate) const DEFAULT_TAB_BAR_COMMAND_TIMEOUT_SECONDS: u64 = 2;
pub(crate) const MAX_TAB_BAR_COMMAND_INTERVAL_SECONDS: u64 = 31_536_000;
pub(crate) const MAX_TAB_BAR_COMMAND_TIMEOUT_SECONDS: u64 = 3_600;
pub(crate) const MAX_TAB_BAR_RIGHT_ENTRIES: usize = 16;
fn default_datetime_format() -> String {
"%H:%M".to_string()
}
fn default_command_interval_seconds() -> u64 {
DEFAULT_TAB_BAR_COMMAND_INTERVAL_SECONDS
}
fn default_command_timeout_seconds() -> u64 {
DEFAULT_TAB_BAR_COMMAND_TIMEOUT_SECONDS
}
#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]
#[serde(tag = "type", rename_all = "snake_case", deny_unknown_fields)]
pub enum TabBarRightEntryConfig {
Zoom,
Hostname,
Datetime {
#[serde(default = "default_datetime_format")]
format: String,
},
Text {
text: String,
},
Command {
command: String,
#[serde(default = "default_command_interval_seconds")]
interval_seconds: u64,
#[serde(default = "default_command_timeout_seconds")]
timeout_seconds: u64,
},
}
pub(crate) fn parse_tab_bar_datetime_format(
value: &str,
) -> Result<time::format_description::OwnedFormatItem, String> {
if value.is_empty() {
return Err("datetime format is empty".into());
}
let format = time::format_description::parse_strftime_owned(value)
.map_err(|err| format!("invalid datetime format: {err}"))?;
time::PrimitiveDateTime::MIN
.format(&format)
.map_err(|err| format!("unsupported datetime format: {err}"))?;
Ok(format)
}
pub(crate) fn tab_bar_right_diagnostics(entries: &[TabBarRightEntryConfig]) -> Vec<String> {
let mut diagnostics = Vec::new();
if entries.len() > MAX_TAB_BAR_RIGHT_ENTRIES {
diagnostics.push(format!(
"ui.tab_bar_right may contain at most {MAX_TAB_BAR_RIGHT_ENTRIES} entries; ignoring extras"
));
}
for (index, entry) in entries.iter().enumerate().take(MAX_TAB_BAR_RIGHT_ENTRIES) {
match entry {
TabBarRightEntryConfig::Datetime { format } => {
if format.is_empty() {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] datetime format is empty; hiding entry"
));
} else if let Err(err) = parse_tab_bar_datetime_format(format) {
diagnostics.push(format!("ui.tab_bar_right[{index}] has {err}; hiding entry"));
}
}
TabBarRightEntryConfig::Command {
command,
interval_seconds,
timeout_seconds,
} => {
if command.trim().is_empty() {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] command is empty; hiding entry"
));
}
if *interval_seconds == 0 {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] interval_seconds must be at least 1; hiding entry"
));
}
if *interval_seconds > MAX_TAB_BAR_COMMAND_INTERVAL_SECONDS {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] interval_seconds may be at most {MAX_TAB_BAR_COMMAND_INTERVAL_SECONDS}; hiding entry"
));
}
if *timeout_seconds == 0 {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] timeout_seconds must be at least 1; hiding entry"
));
}
if *timeout_seconds > MAX_TAB_BAR_COMMAND_TIMEOUT_SECONDS {
diagnostics.push(format!(
"ui.tab_bar_right[{index}] timeout_seconds may be at most {MAX_TAB_BAR_COMMAND_TIMEOUT_SECONDS}; hiding entry"
));
}
}
TabBarRightEntryConfig::Zoom
| TabBarRightEntryConfig::Hostname
| TabBarRightEntryConfig::Text { .. } => {}
}
}
diagnostics
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn tab_bar_entries_parse_with_command_defaults() {
#[derive(Deserialize)]
struct Wrapper {
entries: Vec<TabBarRightEntryConfig>,
}
let parsed: Wrapper = toml::from_str(
r#"
entries = [
{ type = "zoom" },
{ type = "hostname" },
{ type = "datetime", format = "%H:%M" },
{ type = "text", text = "prod" },
{ type = "command", command = "status.sh" },
]
"#,
)
.expect("parse tab bar entries");
assert_eq!(parsed.entries.len(), 5);
assert!(matches!(
&parsed.entries[4],
TabBarRightEntryConfig::Command {
interval_seconds: DEFAULT_TAB_BAR_COMMAND_INTERVAL_SECONDS,
timeout_seconds: DEFAULT_TAB_BAR_COMMAND_TIMEOUT_SECONDS,
..
}
));
}
#[test]
fn diagnostics_reject_invalid_datetime_and_command_schedules() {
let entries = vec![
TabBarRightEntryConfig::Datetime {
format: "%Q".into(),
},
TabBarRightEntryConfig::Datetime {
format: "%z".into(),
},
TabBarRightEntryConfig::Command {
command: String::new(),
interval_seconds: 0,
timeout_seconds: 0,
},
TabBarRightEntryConfig::Command {
command: "status.sh".into(),
interval_seconds: MAX_TAB_BAR_COMMAND_INTERVAL_SECONDS + 1,
timeout_seconds: MAX_TAB_BAR_COMMAND_TIMEOUT_SECONDS + 1,
},
];
let diagnostics = tab_bar_right_diagnostics(&entries).join("\n");
assert!(diagnostics.contains("invalid datetime format"));
assert!(diagnostics.contains("unsupported datetime format"));
assert!(diagnostics.contains("command is empty"));
assert!(diagnostics.contains("interval_seconds must be at least 1"));
assert!(diagnostics.contains("interval_seconds may be at most"));
assert!(diagnostics.contains("timeout_seconds must be at least 1"));
assert!(diagnostics.contains("timeout_seconds may be at most"));
assert!(parse_tab_bar_datetime_format("").is_err());
}
}
|
