1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
|
use std::time::Instant;
#[cfg(test)]
use std::time::Duration;
use crossterm::terminal;
use super::{
background_update_check_enabled, pressed_key_identity, App, AUTO_UPDATE_CHECK_INTERVAL,
MIN_RENDER_INTERVAL, RESIZE_POLL_INTERVAL, SELECTION_AUTOSCROLL_INTERVAL,
};
fn retain_custom_command_after_wait(
pid: u32,
result: std::io::Result<Option<std::process::ExitStatus>>,
) -> bool {
match result {
Ok(None) => true,
Ok(Some(_)) => false,
Err(err) if err.kind() == std::io::ErrorKind::Interrupted => true,
Err(err) => {
tracing::warn!(pid, err = %err, "failed to reap detached custom command");
false
}
}
}
impl App {
pub(crate) fn reap_finished_custom_commands(&mut self) {
self.detached_custom_command_children
.retain_mut(|child| retain_custom_command_after_wait(child.id(), child.try_wait()));
}
pub(crate) fn shutdown_detached_terminal_runtimes(&mut self) {
let terminal_ids = std::mem::take(&mut self.state.terminal_runtime_shutdowns);
for terminal_id in terminal_ids {
if let Some(runtime) = self.terminal_runtimes.remove(&terminal_id) {
runtime.shutdown();
}
}
}
pub(crate) fn drain_api_requests(&mut self) -> bool {
let mut changed = false;
while let Ok(msg) = self.api_rx.try_recv() {
changed |= self.handle_api_request_message(msg);
self.shutdown_detached_terminal_runtimes();
}
changed
}
pub(super) fn handle_api_request_message(
&mut self,
msg: crate::api::ApiRequestMessage,
) -> bool {
let previous_mode = self.state.mode;
let mut changed = self.expire_due_metadata(Instant::now());
changed |= crate::api::request_changes_ui(&msg.request);
let skip_default_workspace = matches!(
&msg.request.method,
crate::api::schema::Method::ServerStop(_)
| crate::api::schema::Method::ServerLiveHandoff(_)
);
if matches!(
&msg.request.method,
crate::api::schema::Method::WorktreeCreate(_)
| crate::api::schema::Method::WorktreeRemove(_)
) {
self.drain_all_internal_events();
let deferred_changed =
self.handle_deferred_worktree_api_request(msg.request, msg.respond_to);
if !skip_default_workspace {
changed |= self.ensure_default_workspace();
}
self.sync_prefix_input_source(previous_mode);
return changed | deferred_changed;
}
let response = self.handle_api_request(msg.request);
if !skip_default_workspace {
changed |= self.ensure_default_workspace();
}
let _ = msg.respond_to.send(response);
self.sync_prefix_input_source(previous_mode);
changed
}
pub(super) async fn handle_raw_input_batch(
&mut self,
first: crate::raw_input::RawInputEvent,
) -> bool {
let mut changed = self.handle_raw_input_event(first).await;
while let Some(rx) = self.input_rx.as_mut() {
match rx.try_recv() {
Ok(event) => changed |= self.handle_raw_input_event(event).await,
Err(tokio::sync::mpsc::error::TryRecvError::Empty) => break,
Err(tokio::sync::mpsc::error::TryRecvError::Disconnected) => {
self.input_rx = None;
break;
}
}
}
changed
}
pub(super) async fn handle_raw_input_event(
&mut self,
event: crate::raw_input::RawInputEvent,
) -> bool {
let previous_mode = self.state.mode;
let changed = match event {
crate::raw_input::RawInputEvent::Key(key) => {
let pressed_key_id = pressed_key_identity(super::LOCAL_INPUT_SOURCE, &key);
match key.kind {
crossterm::event::KeyEventKind::Press => {
if self.state.popup_pane.is_some()
|| self.state.mode == crate::app::Mode::Terminal
{
self.suppressed_repeat_keys.remove(&pressed_key_id);
} else {
self.suppressed_repeat_keys.insert(pressed_key_id);
}
if let Some(target) = self.handle_key(key).await {
if !key.is_text_commit {
self.pressed_terminal_keys.insert(
pressed_key_id,
super::PressedTerminalKey { target, key },
);
}
} else {
self.pressed_terminal_keys.remove(&pressed_key_id);
}
true
}
crossterm::event::KeyEventKind::Repeat => {
if let Some(pressed) =
self.pressed_terminal_keys.get(&pressed_key_id).cloned()
{
if !self
.forward_terminal_key_to_target(&pressed.target, key)
.await
{
self.pressed_terminal_keys.remove(&pressed_key_id);
}
true
} else if (self.state.popup_pane.is_some()
|| self.state.mode == crate::app::Mode::Terminal)
&& !self.suppressed_repeat_keys.contains(&pressed_key_id)
{
self.handle_key(key).await;
true
} else {
false
}
}
crossterm::event::KeyEventKind::Release => {
self.suppressed_repeat_keys.remove(&pressed_key_id);
if let Some(pressed) = self.pressed_terminal_keys.remove(&pressed_key_id) {
let _ = self
.forward_terminal_key_to_target(&pressed.target, key)
.await;
}
false
}
}
}
crate::raw_input::RawInputEvent::Paste(text) => {
self.handle_paste(text).await;
true
}
crate::raw_input::RawInputEvent::Mouse(mouse) => {
let changes_view = !matches!(mouse.kind, crossterm::event::MouseEventKind::Moved)
|| self.state.mode.mouse_motion_changes_view();
if self.state.popup_pane.is_some() || self.state.mouse_capture {
self.handle_mouse(mouse);
} else {
self.state
.handle_pane_mouse_only(&self.terminal_runtimes, mouse);
}
changes_view
}
crate::raw_input::RawInputEvent::OuterFocusGained => {
self.send_outer_focus_event(crate::ghostty::FocusEvent::Gained);
if self.state.redraw_on_focus_gained {
self.request_repaint();
}
self.state.outer_terminal_focus = Some(true);
self.state.mark_active_tab_seen();
true
}
crate::raw_input::RawInputEvent::OuterFocusLost => {
self.release_input_source(super::LOCAL_INPUT_SOURCE).await;
self.send_outer_focus_event(crate::ghostty::FocusEvent::Lost);
self.state.outer_terminal_focus = Some(false);
false
}
crate::raw_input::RawInputEvent::HostDefaultColor { kind, color } => {
self.update_host_terminal_theme(kind, color)
}
crate::raw_input::RawInputEvent::HostPaletteColors { colors } => {
self.update_host_terminal_palette_colors(&colors)
}
crate::raw_input::RawInputEvent::HostColorSchemeChanged(appearance) => {
self.query_host_terminal_theme();
self.set_host_terminal_appearance(appearance, true)
}
crate::raw_input::RawInputEvent::Unsupported => false,
};
self.sync_prefix_input_source(previous_mode);
self.shutdown_detached_terminal_runtimes();
changed
}
fn handle_resize_poll(&mut self) -> bool {
let Ok(size) = terminal::size() else {
return false;
};
if self.last_terminal_size != Some(size) {
self.last_terminal_size = Some(size);
return true;
}
false
}
pub(crate) fn handle_scheduled_tasks(&mut self, now: Instant, geometry_dirty: bool) -> bool {
let mut changed = false;
let mut resized = false;
if now >= self.next_resize_poll {
resized = self.handle_resize_poll();
changed |= resized;
self.next_resize_poll = now + RESIZE_POLL_INTERVAL;
}
if self
.config_diagnostic_deadline
.is_some_and(|deadline| now >= deadline)
{
self.config_diagnostic_deadline = None;
self.state.config_diagnostic = None;
changed = true;
}
if self.toast_deadline.is_some_and(|deadline| now >= deadline) {
self.toast_deadline = None;
self.state.toast = None;
changed = true;
}
if self
.state
.next_pending_agent_notification_deadline()
.is_some_and(|deadline| now >= deadline)
{
let previous_toast = self.state.toast.clone();
let mut deliveries = self.state.drain_due_agent_notifications(now);
if !deliveries.is_empty() {
self.refresh_agent_notification_delivery_contexts(&mut deliveries);
self.emit_delayed_client_local_agent_notifications(&deliveries);
self.sync_toast_deadline(previous_toast);
changed = true;
}
}
if self
.state
.next_managed_agent_deadline()
.is_some_and(|deadline| now >= deadline)
{
let panes = self.state.reconcile_managed_agents_at(now);
if !panes.is_empty() {
for (ws_idx, pane_id) in panes {
self.emit_pane_updated(ws_idx, pane_id);
}
self.schedule_session_save();
changed = true;
}
}
if self
.copy_feedback_deadline
.is_some_and(|deadline| now >= deadline)
{
self.copy_feedback_deadline = None;
self.state.copy_feedback = None;
changed = true;
}
if self
.selection_autoscroll_deadline
.is_some_and(|deadline| now >= deadline)
{
self.tick_selection_autoscroll(now);
changed = true;
}
changed |= self.clear_due_selection_highlight(now);
self.start_git_status_refresh_if_due(now);
if self
.next_auto_update_check
.is_some_and(|deadline| now >= deadline)
{
self.run_auto_update_check();
}
if self
.next_agent_manifest_update_check
.is_some_and(|deadline| now >= deadline)
{
self.run_agent_manifest_update_check();
}
if self
.session_save_deadline
.is_some_and(|deadline| now >= deadline)
{
self.start_background_session_save();
}
changed |= self.expire_due_metadata(now);
if geometry_dirty || resized {
self.pending_agent_resume_deadline = None;
} else {
self.sync_pending_agent_resume_deadline(now);
changed |= self.start_pending_agent_resumes(self.pending_agent_resume_due(now));
}
changed
}
/// Clears temporary copied-token highlights, such as after double-click copy.
pub(crate) fn clear_due_selection_highlight(&mut self, now: Instant) -> bool {
if self
.selection_highlight_clear_deadline
.is_none_or(|deadline| now < deadline)
{
return false;
}
self.selection_highlight_clear_deadline = None;
if self
.state
.selection
.as_ref()
.is_some_and(|selection| !selection.is_in_progress())
{
self.state.clear_selection();
return true;
}
false
}
pub(crate) fn sync_agent_metadata_deadline(&mut self) {
self.agent_metadata_deadline = self.state.next_agent_metadata_expiry();
}
pub(crate) fn expire_due_metadata(&mut self, now: Instant) -> bool {
let Some(deadline) = self
.agent_metadata_deadline
.filter(|deadline| now >= *deadline)
else {
return false;
};
self.expire_metadata_at(deadline, now);
true
}
pub(crate) fn expire_metadata_at(&mut self, deadline: Instant, now: Instant) {
let previous_toast = self.state.toast.clone();
for update in self.state.expire_agent_metadata_at(deadline, now) {
self.refresh_new_herdr_toast_context_for_update(&update, &previous_toast);
self.emit_pane_state_update(&update);
}
let (panes, workspaces) = self.state.expire_metadata_tokens(now);
for (ws_idx, pane_id) in panes {
self.emit_pane_updated(ws_idx, pane_id);
}
for ws_idx in workspaces {
self.emit_workspace_token_updated(ws_idx);
}
self.sync_agent_metadata_deadline();
}
pub(crate) fn tick_selection_autoscroll(&mut self, now: Instant) {
let Some(autoscroll) = self.state.selection_autoscroll.clone() else {
// Self-heal: state cleared but deadline leaked
self.selection_autoscroll_deadline = None;
return;
};
// Selection must still be in progress for autoscroll to continue
let Some(pane_id) = self.state.selection.as_ref().map(|s| s.pane_id) else {
self.stop_selection_autoscroll();
return;
};
if !self
.state
.selection
.as_ref()
.is_some_and(|s| s.is_dragging())
{
self.stop_selection_autoscroll();
return;
}
// Rect-change detection: if inner_rect changed since drag, stop
let current_rect = self
.state
.pane_info_by_id(pane_id)
.map(|info| info.inner_rect);
if current_rect != Some(autoscroll.inner_rect) {
self.stop_selection_autoscroll();
return;
}
// Scrollback boundary detection via ScrollMetrics — fail-closed if unavailable
let Some(metrics) = self
.state
.pane_scroll_metrics(&self.terminal_runtimes, pane_id)
else {
self.stop_selection_autoscroll();
return;
};
match autoscroll.direction {
crate::app::state::SelectionAutoscrollDirection::Up => {
let at_top = metrics.offset_from_bottom >= metrics.max_offset_from_bottom;
if at_top {
self.stop_selection_autoscroll();
return;
}
self.state
.scroll_pane_up(&self.terminal_runtimes, pane_id, 1);
}
crate::app::state::SelectionAutoscrollDirection::Down => {
let at_bottom = metrics.offset_from_bottom == 0;
if at_bottom {
self.stop_selection_autoscroll();
return;
}
self.state
.scroll_pane_down(&self.terminal_runtimes, pane_id, 1);
}
}
// Extend selection cursor to last known mouse position
self.state.update_selection_cursor(
&self.terminal_runtimes,
pane_id,
autoscroll.last_mouse_screen_col,
autoscroll.last_mouse_screen_row,
);
// Reschedule
self.selection_autoscroll_deadline = Some(now + SELECTION_AUTOSCROLL_INTERVAL);
}
pub(crate) fn stop_selection_autoscroll(&mut self) {
self.state.stop_selection_autoscroll_state();
self.selection_autoscroll_deadline = None;
}
pub(crate) fn can_render_now(&self, now: Instant) -> bool {
match self.last_render_at {
Some(last_render_at) => now.duration_since(last_render_at) >= MIN_RENDER_INTERVAL,
None => true,
}
}
pub(crate) fn run_auto_update_check(&mut self) {
if !background_update_check_enabled(self.no_session, self.update_version_check_enabled) {
self.next_auto_update_check = None;
return;
}
self.next_auto_update_check = self
.state
.update_available
.is_none()
.then_some(Instant::now() + AUTO_UPDATE_CHECK_INTERVAL);
if self.state.update_available.is_some() {
return;
}
let update_tx = self.event_tx.clone();
std::thread::spawn(move || crate::update::auto_update(update_tx));
}
pub(crate) fn run_agent_manifest_update_check(&mut self) {
if !background_update_check_enabled(self.no_session, self.update_manifest_check_enabled) {
self.next_agent_manifest_update_check = None;
return;
}
self.next_agent_manifest_update_check = Some(Instant::now() + AUTO_UPDATE_CHECK_INTERVAL);
let manifest_update_tx = self.event_tx.clone();
std::thread::spawn(move || crate::detect::manifest_update::auto_update(manifest_update_tx));
}
pub(crate) fn next_loop_deadline(&self, now: Instant, needs_render: bool) -> Option<Instant> {
self.next_loop_deadline_with_resize_poll(now, needs_render, true, true)
}
pub(crate) fn next_headless_loop_deadline_with_git_refresh(
&self,
now: Instant,
needs_render: bool,
include_git_refresh: bool,
) -> Option<Instant> {
self.next_loop_deadline_with_resize_poll(now, needs_render, false, include_git_refresh)
}
fn next_loop_deadline_with_resize_poll(
&self,
now: Instant,
needs_render: bool,
include_resize_poll: bool,
include_git_refresh: bool,
) -> Option<Instant> {
let render_deadline = if needs_render {
self.last_render_at
.map(|last_render_at| last_render_at + MIN_RENDER_INTERVAL)
.filter(|deadline| *deadline > now)
} else {
None
};
[
include_resize_poll.then_some(self.next_resize_poll),
self.config_diagnostic_deadline,
self.toast_deadline,
self.state.next_pending_agent_notification_deadline(),
self.state.next_managed_agent_deadline(),
self.copy_feedback_deadline,
include_git_refresh
.then(|| self.git_refresh_deadline())
.flatten(),
self.next_auto_update_check,
self.next_agent_manifest_update_check,
self.agent_metadata_deadline,
self.pending_agent_resume_deadline,
self.session_save_deadline,
self.selection_autoscroll_deadline,
self.selection_highlight_clear_deadline,
render_deadline,
]
.into_iter()
.flatten()
.min()
}
pub(crate) fn drain_internal_events(&mut self) -> bool {
self.drain_internal_events_up_to(super::APP_EVENT_DRAIN_LIMIT)
.1
}
pub(crate) fn drain_all_internal_events(&mut self) -> bool {
let mut changed = false;
loop {
let (had_event, batch_changed) =
self.drain_internal_events_up_to(super::APP_EVENT_DRAIN_LIMIT);
changed |= batch_changed;
if !had_event {
break;
}
}
changed
}
fn drain_internal_events_up_to(&mut self, limit: usize) -> (bool, bool) {
let mut had_event = false;
let mut changed = false;
for _ in 0..limit {
let Ok(ev) = self.event_rx.try_recv() else {
break;
};
had_event = true;
changed |= self.handle_internal_event_with_prefix_sync(ev);
}
(had_event, changed)
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::app::state;
use crate::workspace::Workspace;
#[test]
fn interrupted_custom_command_wait_keeps_child_for_retry() {
let interrupted = std::io::Error::new(std::io::ErrorKind::Interrupted, "test interrupt");
assert!(retain_custom_command_after_wait(42, Err(interrupted)));
}
fn test_app_with_pane() -> (super::super::App, crate::layout::PaneId) {
let mut app = super::super::App::new(
&crate::config::Config::default(),
true,
None,
tokio::sync::mpsc::unbounded_channel().1,
crate::api::EventHub::default(),
);
let ws = Workspace::test_new("test");
let pane_id = ws.tabs[0].root_pane;
app.state.workspaces.push(ws);
app.state.active = Some(0);
app.state.view.pane_infos.push(crate::layout::PaneInfo {
id: pane_id,
rect: ratatui::layout::Rect::new(0, 0, 80, 24),
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
scrollbar_rect: None,
borders: ratatui::widgets::Borders::NONE,
is_focused: true,
});
(app, pane_id)
}
#[test]
fn tick_selection_autoscroll_stops_when_metrics_unavailable() {
// Without a runtime, pane_scroll_metrics returns None.
// Fail-closed: stop autoscroll instead of rescheduling forever.
let (mut app, pane_id) = test_app_with_pane();
let now = Instant::now();
let mut sel = crate::selection::Selection::anchor(pane_id, 0, 0, None);
// Drag to a different cell so it becomes Dragging
sel.drag(5, 5, ratatui::layout::Rect::new(0, 0, 80, 24), None);
app.state.selection = Some(sel);
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Down,
last_mouse_screen_col: 5,
last_mouse_screen_row: 23,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
// Should stop because no runtime metrics available
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
#[test]
fn tick_selection_autoscroll_stops_when_selection_done() {
let (mut app, pane_id) = test_app_with_pane();
let now = Instant::now();
// Create a selection that is already finished (not in progress)
let mut sel = crate::selection::Selection::anchor(pane_id, 0, 0, None);
// Drag to a different cell so it becomes visible, then finish
sel.drag(5, 5, ratatui::layout::Rect::new(0, 0, 80, 24), None);
sel.finish(); // now it's Done, not in progress
app.state.selection = Some(sel);
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Down,
last_mouse_screen_col: 0,
last_mouse_screen_row: 23,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
#[test]
fn tick_selection_autoscroll_stops_when_selection_cleared() {
let (mut app, _pane_id) = test_app_with_pane();
let now = Instant::now();
app.state.selection = None;
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Down,
last_mouse_screen_col: 0,
last_mouse_screen_row: 23,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
#[test]
fn tick_selection_autoscroll_stops_when_selection_anchored() {
// Anchored (click, no drag) should not keep the timer running.
let (mut app, pane_id) = test_app_with_pane();
let now = Instant::now();
app.state.selection = Some(crate::selection::Selection::anchor(pane_id, 0, 0, None));
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Down,
last_mouse_screen_col: 0,
last_mouse_screen_row: 23,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
/// Creates an app with a real TerminalRuntime (no PTY) so scroll_metrics
/// returns meaningful data. Uses test_with_scrollback_bytes.
fn test_app_with_runtime(
cols: u16,
rows: u16,
bytes: &[u8],
) -> (super::super::App, crate::layout::PaneId) {
let mut app = super::super::App::new(
&crate::config::Config::default(),
true,
None,
tokio::sync::mpsc::unbounded_channel().1,
crate::api::EventHub::default(),
);
let mut ws = Workspace::test_new("test");
let pane_id = ws.tabs[0].root_pane;
let runtime =
crate::terminal::TerminalRuntime::test_with_scrollback_bytes(cols, rows, 0, bytes);
ws.tabs[0].runtimes.insert(pane_id, runtime);
app.state.workspaces.push(ws);
app.state.active = Some(0);
app.state.view.pane_infos.push(crate::layout::PaneInfo {
id: pane_id,
rect: ratatui::layout::Rect::new(0, 0, cols, rows),
inner_rect: ratatui::layout::Rect::new(0, 0, cols, rows),
scrollbar_rect: None,
borders: ratatui::widgets::Borders::NONE,
is_focused: true,
});
(app, pane_id)
}
#[tokio::test]
async fn tick_selection_autoscroll_stops_at_scrollback_top() {
// Create a runtime with no scrollback content — we're already at
// the top (offset_from_bottom == max_offset_from_bottom).
let (mut app, pane_id) = test_app_with_runtime(80, 24, &[]);
let now = Instant::now();
let mut sel = crate::selection::Selection::anchor(pane_id, 5, 5, None);
sel.drag(0, 0, ratatui::layout::Rect::new(0, 0, 80, 24), None);
app.state.selection = Some(sel);
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Up,
last_mouse_screen_col: 0,
last_mouse_screen_row: 0,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
// At scrollback top, can't scroll further up — should stop
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
#[tokio::test]
async fn tick_selection_autoscroll_stops_at_scrollback_bottom() {
// Create a runtime with no scrollback content — we're already at
// the bottom (offset_from_bottom == 0).
let (mut app, pane_id) = test_app_with_runtime(80, 24, &[]);
let now = Instant::now();
let mut sel = crate::selection::Selection::anchor(pane_id, 0, 0, None);
sel.drag(5, 5, ratatui::layout::Rect::new(0, 0, 80, 24), None);
app.state.selection = Some(sel);
app.state.selection_autoscroll = Some(state::SelectionAutoscroll {
direction: state::SelectionAutoscrollDirection::Down,
last_mouse_screen_col: 5,
last_mouse_screen_row: 23,
inner_rect: ratatui::layout::Rect::new(0, 0, 80, 24),
});
app.selection_autoscroll_deadline = Some(now);
app.tick_selection_autoscroll(now);
// At scrollback bottom, can't scroll further down — should stop
assert!(app.state.selection_autoscroll.is_none());
assert!(app.selection_autoscroll_deadline.is_none());
}
#[tokio::test]
async fn passive_mouse_motion_does_not_request_monolithic_render() {
let (mut app, _) = test_app_with_pane();
app.state.mode = crate::app::Mode::Terminal;
let motion = || {
crate::raw_input::RawInputEvent::Mouse(crossterm::event::MouseEvent {
kind: crossterm::event::MouseEventKind::Moved,
column: 10,
row: 5,
modifiers: crossterm::event::KeyModifiers::empty(),
})
};
assert!(!app.handle_raw_input_event(motion()).await);
app.state.mode = crate::app::Mode::GlobalMenu;
assert!(app.handle_raw_input_event(motion()).await);
}
#[tokio::test]
async fn raw_input_batch_does_not_start_pending_agent_resume_before_render() {
let (mut app, pane_id) = test_app_with_pane();
app.state.ensure_test_terminals();
let terminal_id = app.state.workspaces[0]
.terminal_id(pane_id)
.cloned()
.expect("test pane should have a terminal");
app.state
.terminals
.get_mut(&terminal_id)
.expect("test terminal should exist")
.pending_agent_resume_plan = Some(crate::agent_resume::AgentResumePlan {
agent: "codex".into(),
argv: vec!["/bin/sh".into(), "-c".into(), "sleep 5".into()],
dedupe_key: "herdr:codex\0codex\0Id\0codex-session".into(),
});
assert!(
app.handle_raw_input_batch(crate::raw_input::RawInputEvent::HostDefaultColor {
kind: crate::terminal_theme::DefaultColorKind::Foreground,
color: crate::terminal_theme::RgbColor {
r: 220,
g: 220,
b: 220,
},
})
.await
);
assert!(
app.terminal_runtimes.get(&terminal_id).is_none(),
"raw input can mutate active geometry; pending resumes must wait for render to refresh pane_infos"
);
assert!(app
.state
.terminals
.get(&terminal_id)
.expect("test terminal should still exist")
.pending_agent_resume_plan
.is_some());
}
#[tokio::test]
async fn scheduled_tasks_do_not_start_pending_agent_resume_when_geometry_dirty() {
let (mut app, pane_id) = test_app_with_pane();
app.state.ensure_test_terminals();
app.state.host_terminal_theme = crate::terminal_theme::TerminalTheme {
foreground: Some(crate::terminal_theme::RgbColor {
r: 220,
g: 220,
b: 220,
}),
background: Some(crate::terminal_theme::RgbColor {
r: 20,
g: 20,
b: 20,
}),
..Default::default()
};
let terminal_id = app.state.workspaces[0]
.terminal_id(pane_id)
.cloned()
.expect("test pane should have a terminal");
app.state
.terminals
.get_mut(&terminal_id)
.expect("test terminal should exist")
.pending_agent_resume_plan = Some(crate::agent_resume::AgentResumePlan {
agent: "codex".into(),
argv: vec!["/bin/sh".into(), "-c".into(), "sleep 5".into()],
dedupe_key: "herdr:codex\0codex\0Id\0codex-session".into(),
});
app.pending_agent_resume_deadline = Some(Instant::now() - Duration::from_millis(1));
assert!(!app.handle_scheduled_tasks(Instant::now(), true));
assert!(app.terminal_runtimes.get(&terminal_id).is_none());
assert!(app
.state
.terminals
.get(&terminal_id)
.expect("test terminal should still exist")
.pending_agent_resume_plan
.is_some());
assert!(app.pending_agent_resume_deadline.is_none());
}
}
|