1 files changed, 35 insertions, 1 deletions
diff --git a/src/cli/plugin.rs b/src/cli/plugin.rs
index 261540c7..5cc528f4 100644
--- a/src/cli/plugin.rs
+++ b/src/cli/plugin.rs
@@ -12,6 +12,7 @@ use crate::api::schema::{
     PluginPlatform, PluginSetEnabledParams, PluginSourceInfo, PluginSourceKind, PluginUnlinkParams,
     Request, ResponseResult, SplitDirection, SuccessResponse,
 };
+use crate::popup_size::PopupSize;
 
 const PLUGIN_BUILD_OUTPUT_MAX_BYTES: usize = 64 * 1024;
 
@@ -487,6 +488,8 @@ fn plugin_pane_open(args: &[String]) -> std::io::Result<i32> {
     let mut plugin_id = None;
     let mut entrypoint = None;
     let mut placement = None;
+    let mut width = None;
+    let mut height = None;
     let mut workspace_id = None;
     let mut target_pane_id = None;
     let mut direction = None;
@@ -518,6 +521,24 @@ fn plugin_pane_open(args: &[String]) -> std::io::Result<i32> {
                 };
                 placement = Some(parsed);
             }
+            "--width" => {
+                let Some(value) = required_value(args, &mut index, "--width") else {
+                    return Ok(2);
+                };
+                let Some(parsed) = parse_popup_dimension(&value, "--width") else {
+                    return Ok(2);
+                };
+                width = Some(parsed);
+            }
+            "--height" => {
+                let Some(value) = required_value(args, &mut index, "--height") else {
+                    return Ok(2);
+                };
+                let Some(parsed) = parse_popup_dimension(&value, "--height") else {
+                    return Ok(2);
+                };
+                height = Some(parsed);
+            }
             "--workspace" => {
                 let Some(value) = required_value(args, &mut index, "--workspace") else {
                     return Ok(2);
@@ -586,6 +607,8 @@ fn plugin_pane_open(args: &[String]) -> std::io::Result<i32> {
         plugin_id,
         entrypoint,
         placement,
+        width,
+        height,
         workspace_id,
         target_pane_id,
         direction,
@@ -595,6 +618,16 @@ fn plugin_pane_open(args: &[String]) -> std::io::Result<i32> {
     }))
 }
 
+fn parse_popup_dimension(value: &str, flag: &str) -> Option<PopupSize> {
+    match PopupSize::parse_cli(value) {
+        Ok(value) => Some(value),
+        Err(message) => {
+            eprintln!("{flag} {message}");
+            None
+        }
+    }
+}
+
 fn plugin_pane_focus(args: &[String]) -> std::io::Result<i32> {
     let Some(pane_id) = args.first() else {
         eprintln!("usage: herdr plugin pane focus <pane_id>");
@@ -635,6 +668,7 @@ fn required_value(args: &[String], index: &mut usize, flag: &str) -> Option<Stri
 fn parse_pane_placement(value: &str) -> Option<PluginPanePlacement> {
     match value {
         "overlay" => Some(PluginPanePlacement::Overlay),
+        "popup" => Some(PluginPanePlacement::Popup),
         "split" => Some(PluginPanePlacement::Split),
         "tab" => Some(PluginPanePlacement::Tab),
         "zoomed" | "fullscreen" => Some(PluginPanePlacement::Zoomed),
@@ -1604,7 +1638,7 @@ fn print_plugin_action_help() {
 
 fn print_plugin_pane_help() {
     eprintln!("herdr plugin pane commands:");
-    eprintln!("  herdr plugin pane open --plugin ID --entrypoint ID [--placement overlay|split|tab|zoomed] [--workspace ID] [--target-pane PANE] [--direction right|down] [--cwd PATH] [--env KEY=VALUE] [--focus|--no-focus]");
+    eprintln!("  herdr plugin pane open --plugin ID --entrypoint ID [--placement overlay|popup|split|tab|zoomed] [--width SIZE] [--height SIZE] [--workspace ID] [--target-pane PANE] [--direction right|down] [--cwd PATH] [--env KEY=VALUE] [--focus|--no-focus]");
     eprintln!("  herdr plugin pane focus <pane_id>");
     eprintln!("  herdr plugin pane close <pane_id>");
 }