diff options
| author | Can Celik <ogulcancelik@gmail.com> | 2026-08-19 04:43:28 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-08-19 04:43:28 +0300 |
| commit | a5c69beabfc82d9c3f9563eb821139b2e0f3e14f (patch) | |
| tree | 9b7049e4629913dcab40d985df399acee262b67b /vendor/libghostty-vt.patches.md | |
| parent | 3667151744e379ac5c8f76d57203b675de8a6ebc (diff) | |
fix(perf): eliminate redundant terminal wake work (#2962)
* fix(perf): eliminate redundant terminal wake work
* fix(perf): harden release benchmark gate
* test(perf): strengthen performance guardrails
Diffstat (limited to 'vendor/libghostty-vt.patches.md')
| -rw-r--r-- | vendor/libghostty-vt.patches.md | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/vendor/libghostty-vt.patches.md b/vendor/libghostty-vt.patches.md index 04305960..dff98533 100644 --- a/vendor/libghostty-vt.patches.md +++ b/vendor/libghostty-vt.patches.md @@ -38,3 +38,40 @@ cargo nextest run --locked grapheme_cluster_mode_is_default_and_survives_full_re cargo nextest run --locked grapheme_cluster_mode_renders_flag_emoji_in_single_wide_cell cargo nextest run --locked grapheme_cluster_mode_renders_zwj_family_in_single_wide_cell ``` + +## 0002 expose modifyOtherKeys mode through terminal data + +status: active + +patch: `vendor/patches/libghostty-vt/0002-expose-modify-other-keys-mode.patch` + +herdr issue: none; fixes the performance regression exposed by +https://github.com/herdrdev/herdr/pull/2303 + +upstream discussion: not opened + +upstream pr: not opened + +vendored base: `c5a21edfcbc2d5b46540ad91b7980aca31f5f1f3` + +local files: + +- `vendor/libghostty-vt/include/ghostty/vt/terminal.h` +- `vendor/libghostty-vt/src/terminal/c/terminal.zig` + +reason: Herdr must know whether xterm modifyOtherKeys mode 2 is active to +request printable key releases from the outer terminal. The formatter API can +recover this fact only by formatting the active screen and scrollback. A typed +terminal-data query exposes the authoritative scalar without formatting or +allocation. + +remove when: the vendored source exposes an equivalent scalar query for +modifyOtherKeys mode 2 and Herdr can use it without this patch. + +verification: + +```sh +cargo nextest run --locked modify_other_keys_query_tracks_mode_two +cargo nextest run --locked host_report_all_supplies_printable_releases_for_event_type_only_panes +python3 -m unittest scripts.test_vendor_libghostty_vt scripts.test_ui_hot_path_architecture +``` |
