diff options
| author | Ogulcan Celik <ogulcancelik@gmail.com> | 2026-04-26 00:09:16 +0300 |
|---|---|---|
| committer | Ogulcan Celik <ogulcancelik@gmail.com> | 2026-04-26 00:09:26 +0300 |
| commit | a9c8de7eec3981967623bcf5b421e2ccb584c8b6 (patch) | |
| tree | c0bb235d7079b5c233adda68a42276972c59e99b | |
| parent | b11c756ad95a591fd71f44086584cc1e4d9c6ac7 (diff) | |
chore: use approve command for contributor gate
| -rw-r--r-- | .github/workflows/approve-contributor.yml | 6 | ||||
| -rw-r--r-- | .github/workflows/pr-gate.yml | 2 | ||||
| -rw-r--r-- | CONTRIBUTING.md | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/.github/workflows/approve-contributor.yml b/.github/workflows/approve-contributor.yml index 07176a67..c195fc69 100644 --- a/.github/workflows/approve-contributor.yml +++ b/.github/workflows/approve-contributor.yml @@ -2,7 +2,7 @@ name: Approve Contributor on: issue_comment: - types: [created] + types: [created, edited] jobs: approve: @@ -29,8 +29,8 @@ jobs: const commentBody = context.payload.comment.body || ''; const approvedFile = '.github/APPROVED_CONTRIBUTORS'; - if (!/^\s*lgtm\b/i.test(commentBody)) { - console.log('Comment does not match lgtm'); + if (!/(^|\s)\/approve(?=$|\s)/i.test(commentBody)) { + console.log('Comment does not contain /approve'); core.setOutput('status', 'skipped'); return; } diff --git a/.github/workflows/pr-gate.yml b/.github/workflows/pr-gate.yml index 3621f008..d04fef29 100644 --- a/.github/workflows/pr-gate.yml +++ b/.github/workflows/pr-gate.yml @@ -109,7 +109,7 @@ jobs: '**Next steps:**', '1. Open an issue describing what you want to change and why', '2. Keep it concise and write in your own voice', - '3. If a maintainer approves with `lgtm`, you will be added to the approved contributors list', + '3. If a maintainer approves with `/approve`, you will be added to the approved contributors list', '4. Then you can submit your PR', '', `This PR will be closed automatically. See https://github.com/${context.repo.owner}/${context.repo.repo}/blob/${defaultBranch}/CONTRIBUTING.md for more details.`, diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9362989d..f6be5604 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -26,7 +26,7 @@ If you have a suggestion, disagreement, or contradiction with the current produc We use an approval gate for new contributors. -Before opening your first PR, open an issue describing what you want to change and why. Keep it short. Write in your own voice. If you intend to implement it yourself, add the `intends-to-pr` label. A maintainer will comment `lgtm` if the direction is approved. Once approved, you can open PRs. +Before opening your first PR, open an issue describing what you want to change and why. Keep it short. Write in your own voice. If you intend to implement it yourself, add the `intends-to-pr` label. A maintainer will comment `/approve` if the direction is approved. Once approved, you can open PRs. This exists because AI makes it trivial to generate plausible-looking contributions that do not fit the app. |