diff options
| author | Ogulcan Celik <ogulcancelik@gmail.com> | 2026-09-16 19:22:17 +0300 |
|---|---|---|
| committer | Ogulcan Celik <ogulcancelik@gmail.com> | 2026-09-16 19:22:17 +0300 |
| commit | 2c29fb29e30220bc48d783af90ba8f53b81fd96c (patch) | |
| tree | abe6e2d3d0be10deb5b2486b19648f0a2f3f2946 | |
| parent | 3f78f172d9f9fe1a9422334c5ae03cd5ac685ebd (diff) | |
fix: avoid workstation sdk requirement in preview checks
| -rw-r--r-- | .github/workflows/preview.yml | 4 | ||||
| -rw-r--r-- | scripts/release-workflows.test.ts | 11 |
2 files changed, 14 insertions, 1 deletions
diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index e1cce651..52815087 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -128,7 +128,9 @@ jobs: - name: Run checks if: steps.plan.outputs.should_publish == 'true' - run: just check + run: | + just ci + just docs-contract-test build: needs: preflight diff --git a/scripts/release-workflows.test.ts b/scripts/release-workflows.test.ts index 75097710..edeff232 100644 --- a/scripts/release-workflows.test.ts +++ b/scripts/release-workflows.test.ts @@ -16,6 +16,17 @@ describe("official publishing workflow boundaries", () => { expect(load("ci").on.pull_request).toBeDefined(); }); + test("preview checks do not require a workstation Windows SDK", () => { + const checks = preview.jobs.preflight.steps.find((step: any) => step.name === "Run checks"); + expect(checks.run.trim().split("\n")).toEqual(["just ci", "just docs-contract-test"]); + expect(preview.jobs.build.strategy.matrix.include).toContainEqual({ + target: "x86_64-pc-windows-msvc", + os: "windows-latest", + name: "herdr-windows-x86_64.zip", + }); + expect(preview.jobs.publish.needs).toContain("build"); + }); + test("each publishing job rechecks both actors before using credentials", () => { for (const [workflow, names] of [ [preview, ["preflight", "publish"]], |