aboutsummaryrefslogtreecommitdiff
path: root/test-suite
diff options
context:
space:
mode:
authorTianren Dong <tianrendong.dtr@gmail.com>2026-09-28 19:30:23 -0400
committerTianren Dong <tianrendong.dtr@gmail.com>2026-09-28 19:30:23 -0400
commite6c01048363e35b29ebb66e5f8936bdcf60c2913 (patch)
tree640daa8f30888fe627ff6cae176a5aacbf36b79f /test-suite
parent6c5d31eddd145697f4c6f9d4964000c6e2068cb1 (diff)
Fill whole textareas; cover new tabs' first page with early capture
chrome_fill's triple-click selected one line of a multi-line textarea, so fill replaced only that line. Select value fields with the selectAll editing command before deleting. Early capture now waits for in-flight tab.new creations, so a first page that commits before the tab is tracked is still captured.
Diffstat (limited to 'test-suite')
-rw-r--r--test-suite/unit/console-capture.test.mjs21
-rw-r--r--test-suite/unit/input-reliability.test.mjs12
2 files changed, 32 insertions, 1 deletions
diff --git a/test-suite/unit/console-capture.test.mjs b/test-suite/unit/console-capture.test.mjs
index ba0410b..48430ca 100644
--- a/test-suite/unit/console-capture.test.mjs
+++ b/test-suite/unit/console-capture.test.mjs
@@ -20,7 +20,8 @@ function loadWorker() {
debugger: { onDetach: noop, onEvent: noop },
storage: { session: { get: async () => ({}), set: async () => {} } },
scripting: { executeScript: async (options) => { injected.push(options); return []; } },
- tabs: { get: async () => null },
+ tabs: { get: async () => null, create: async () => { throw new Error("not mocked"); } },
+ tabGroups: { query: async () => [] },
};
const w = { chrome, console, setTimeout, clearTimeout, setInterval: () => 0, navigator: { userAgent: "unit-test" }, fetch: async () => { throw new Error("offline"); } };
w.self = w;
@@ -120,3 +121,21 @@ test("early capture is injected only into tabs Pi owns or tracks", async () => {
assert.deepEqual(h.injected.map((o) => o.target.tabId), [11, 12]);
assert.ok(h.injected.every((o) => o.func.name === "installEarlyCapture" && o.injectImmediately === true));
});
+
+test("a Pi tab whose first page commits before tab.new tracks it still gets early capture", async () => {
+ const h = loadWorker();
+ let commit;
+ h.w.chrome.tabs.create = async (props) => {
+ // Chrome can commit the first document while tab.new is still recording ownership.
+ commit = h.commit(21);
+ return { id: 21, windowId: 1, url: props.url, status: "loading" };
+ };
+ h.w.groupTab = async (tab) => ({ tab: { id: tab.id }, group: { title: "Pi" } });
+ h.w.waitForTabSettled = async () => true;
+ h.w.formatTab = async (tab) => tab;
+ await h.w.dispatch("tab.new", { url: "https://site.test/", background: true, sessionKey: "s" });
+ await commit;
+ assert.deepEqual(h.injected.map((o) => o.target.tabId), [21]);
+ await h.commit(22);
+ assert.deepEqual(h.injected.map((o) => o.target.tabId), [21], "unrelated tabs stay untouched");
+});
diff --git a/test-suite/unit/input-reliability.test.mjs b/test-suite/unit/input-reliability.test.mjs
index 4a47e9c..8ea4bc5 100644
--- a/test-suite/unit/input-reliability.test.mjs
+++ b/test-suite/unit/input-reliability.test.mjs
@@ -215,6 +215,18 @@ for (const perCharacter of [false, true]) {
});
}
+test("fill selects a textarea's whole value with the selectAll command, not just the clicked line", async () => {
+ const h = harness({ tag: "TEXTAREA", editable: false });
+ const result = await h.call("fill", { selector: "#target", text: "NEW", domFallback: false });
+ assert.equal(result.input, "chrome");
+ const keys = h.commands("Input.dispatchKeyEvent");
+ const selectAll = keys.findIndex((c) => (c.params.commands || []).includes("selectAll"));
+ const del = keys.findIndex((c) => c.params.key === "Delete" && c.params.type === "keyDown");
+ assert.ok(selectAll >= 0, "selectAll editing command sent");
+ assert.ok(del > selectAll, "delete follows select-all");
+ assert.equal(h.selected.length, 0, "no DOM range selection for value fields");
+});
+
test("fill refuses to select an unrelated focused editor", async () => {
const h = harness({ initial: "keep this" });
h.page.document.activeElement = { isContentEditable: true, contains: () => false };