aboutsummaryrefslogtreecommitdiff
path: root/extensions
diff options
context:
space:
mode:
authorIgor Soarez <igor@soarez.org>2026-11-18 17:01:55 +0200
committerIgor Soarez <igor@soarez.org>2026-11-18 17:01:55 +0200
commit56e471e85ed636c688cb0eb691618ebbc5e61121 (patch)
treeabeb4677b651ce764613fb6a68648b3d81703583 /extensions
parenta76fbc3b9b82038ab44c04d6379cc2d45e5cecd8 (diff)
extension: name no browser in the agent guidance; Brave was hard-codedHEADmaster
Rule 10 told agents their tabs open in the user's Brave window, wrong for anyone on Chrome or another Chromium browser. Say the user's browser window, and the same in the worker comments and the user-window test. Record that the inactive-tab measurement also holds in Chrome 157.
Diffstat (limited to 'extensions')
-rw-r--r--extensions/chrome-profile-bridge/browser-extension/service_worker.js5
-rw-r--r--extensions/chrome-profile-bridge/index.ts2
2 files changed, 4 insertions, 3 deletions
diff --git a/extensions/chrome-profile-bridge/browser-extension/service_worker.js b/extensions/chrome-profile-bridge/browser-extension/service_worker.js
index dc9f45d..85be0a2 100644
--- a/extensions/chrome-profile-bridge/browser-extension/service_worker.js
+++ b/extensions/chrome-profile-bridge/browser-extension/service_worker.js
@@ -241,7 +241,7 @@ async function agentWindowId() {
// Create a fresh automation target for `sessionKey`: an inactive tab in the session's group's
// window if it has a group (Chrome groups cannot span windows), else in the user's window. A new
-// window only when Brave has none. When the tab goes in a pre-existing window, windowId stays unset.
+// window only when the browser has none. When the tab goes in a pre-existing window, windowId stays unset.
async function createAutomationTarget(sessionKey, groupTitle) {
const existingGroup = groupTitle ? await findGroupRecordByTitle(groupTitle) : null;
const windowId = existingGroup && typeof existingGroup.windowId === "number" ? existingGroup.windowId : await agentWindowId();
@@ -487,6 +487,7 @@ async function inputDebug(params) {
// covered or on another Space. Measured 2026-11-14 in Brave: an inactive tab still takes trusted
// CDP clicks, key presses, text and mouse moves, and screenshots render it live; only mouseWheel
// hangs waiting for a frame that never comes, so chrome.scroll scrolls hidden pages by script.
+// Clicks, text, key presses and screenshots measured the same in Chrome 157 on 2026-11-18.
// A minimized window is untested, so input there still fails up front with an actionable error.
async function pageVisibilityState(tabId) {
try {
@@ -1946,7 +1947,7 @@ async function dispatch(action, params) {
const createParams = { url: params.url || "about:blank", active: foregroundRequested(params) };
if (existingGroup && typeof existingGroup.windowId === "number") createParams.windowId = existingGroup.windowId;
// No group of this session yet: use the window of its automation tab if it has one, else the
- // user's window. A window of its own only when Brave has no window open.
+ // user's window. A window of its own only when the browser has no window open.
let ownWindow = false;
if (createParams.windowId === undefined) {
const home = await resolveOwnedAutomationTarget(sessionKeyOf(params)).catch(() => null);
diff --git a/extensions/chrome-profile-bridge/index.ts b/extensions/chrome-profile-bridge/index.ts
index 8a5e02d..2cbd5da 100644
--- a/extensions/chrome-profile-bridge/index.ts
+++ b/extensions/chrome-profile-bridge/index.ts
@@ -1289,7 +1289,7 @@ Usage rules:
7. If you hit a native file-picker or privileged browser prompt gate, tell the user; generic clicks/typing/CSP gates are handled by Chrome input.
8. Run /chrome doctor when in doubt about connectivity or capabilities.
9. A page can open dialogs you cannot see: alert, confirm, prompt, and the \"Leave site? Changes you made may not be saved\" prompt of a page with unsaved changes. They are dismissed for you (stay, cancel). \`chrome_navigate\` reports one by failing, and \`leaveIfAsked: true\` leaves anyway; use that only when you know nothing unsaved matters, and ask the user when unsure. If a click or key press that should have navigated did nothing, a Leave-site prompt may have stopped it: check the page, then ask the user before discarding anything.
-10. Your tabs open in the user's Brave window, inactive, in your session's own tab group (collapsed to one label). An inactive tab takes clicks, typing and screenshots normally, so you do not need it showing. Reuse your tab (navigate it) rather than opening new ones, and close tabs you opened when you are done with them. Do not open new windows unless the user asks.
+10. Your tabs open in the user's browser window, inactive, in your session's own tab group (collapsed to one label). An inactive tab takes clicks, typing and screenshots normally, so you do not need it showing. Reuse your tab (navigate it) rather than opening new ones, and close tabs you opened when you are done with them. Do not open new windows unless the user asks.
11. If a tool fails saying another extension (a password manager such as 1Password) has a prompt open on the tab, decide whether it is in your way or part of the task. If it is just in your way, call \`chrome_clear_overlay\` for the tab. If you need the user to sign in, authorize or approve something with it, leave it alone and tell the user what you are waiting for. Navigating the tab away also frees it.`;
// Shared handlers, dispatched by the unified /chrome command below.