1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
|
import { test, describe } from "node:test";
import assert from "node:assert/strict";
import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
import { type BrowserState, createStatePersister, defaultState } from "../../src/state";
// Pi session JSONL is append-only, so every appendEntry is permanent. Issue #26: identical
// snapshots were appended on every ownership callback, session_tree and shutdown, growing the
// session file and the branch navigator's "+N custom" chain without bound.
const fakePi = (): { readonly pi: ExtensionAPI; readonly entries: ReadonlyArray<unknown> } => {
const entries: unknown[] = [];
const pi = {
appendEntry: (_customType: string, data?: unknown) => {
entries.push(data);
},
} as unknown as ExtensionAPI;
return { pi, entries };
};
const owned = (...ids: string[]): BrowserState => ({ namespace: "default", ownedTargetIds: ids });
describe("state persister", () => {
test("repeated identical snapshots produce one entry", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
assert.equal(persister.persist(owned("a")), true);
assert.equal(persister.persist(owned("a")), false);
assert.equal(persister.persist(owned("a")), false);
assert.equal(entries.length, 1);
});
test("a changed snapshot is appended, and the same change twice is not", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
persister.persist(owned("a"));
persister.persist(owned("a", "b"));
persister.persist(owned("a", "b"));
persister.persist(owned("a"));
assert.deepEqual(entries.map((e) => (e as BrowserState).ownedTargetIds), [["a"], ["a", "b"], ["a"]]);
});
test("tab order does not count as a change", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
persister.persist(owned("a", "b"));
persister.persist(owned("b", "a"));
assert.equal(entries.length, 1);
});
test("a state restored from the session is not re-appended until it changes", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
persister.markPersisted(owned("a"));
assert.equal(persister.persist(owned("a")), false);
assert.equal(entries.length, 0);
assert.equal(persister.persist(owned("a", "b")), true);
assert.equal(entries.length, 1);
});
test("the window ids are part of the comparison", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
persister.persist({ ...owned("a"), harnessWindowTargetId: "w1", harnessWindowId: 7 });
persister.persist({ ...owned("a"), harnessWindowTargetId: "w1", harnessWindowId: 7 });
persister.persist({ ...owned("a"), harnessWindowTargetId: "w2", harnessWindowId: 8 });
assert.equal(entries.length, 2);
});
test("the default state is persisted once, then skipped", () => {
const { pi, entries } = fakePi();
const persister = createStatePersister(pi);
assert.equal(persister.persist(defaultState()), true);
assert.equal(persister.persist(defaultState()), false);
assert.equal(entries.length, 1);
});
});
|
