1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
|
/**
* Unit tests for browser-process parsing and candidate ranking — no browser.
*
* Ranking exists because a machine can run several Chromium browsers at once.
* Picking the wrong one means launching a profile window into a browser the
* harness is not connected to: the agent sees nothing, and a browser the user
* never pointed us at gets a new window. (That is exactly what happened during
* development before ranking existed.)
*
* Run: npx tsx test/profile/browser-process-test.ts
*/
import { homedir } from "node:os";
import { join } from "node:path";
import { parseUserDataDirFlag, rankBrowserCandidate } from "../../src/profile/browser-process";
let passed = 0;
let failed = 0;
const check = (cond: boolean, label: string): void => {
if (cond) {
passed++;
console.log(` ✓ ${label}`);
} else {
failed++;
console.error(` ✗ ${label}`);
}
};
function main(): void {
// B1: --user-data-dir parsing
{
check(
parseUserDataDirFlag("/opt/google/chrome/chrome --user-data-dir=/tmp/x --foo") === "/tmp/x",
"B1: bare value parsed",
);
check(
parseUserDataDirFlag('chrome.exe --user-data-dir="C:\\Users\\Some Name\\Data" --bar') ===
"C:\\Users\\Some Name\\Data",
"B1: double-quoted value with spaces parsed",
);
check(
parseUserDataDirFlag("chrome --user-data-dir='/home/u/my dir'") === "/home/u/my dir",
"B1: single-quoted value parsed",
);
check(parseUserDataDirFlag("/opt/google/chrome/chrome") === undefined, "B1: absent flag → undefined");
check(parseUserDataDirFlag("chrome --user-data-dir=") === undefined, "B1: empty value → undefined");
}
// B2: an explicit --user-data-dir is decisive in both directions
{
const target = "/tmp/pi-e2e-abc";
const match = rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome", explicitUserDataDir: target }, target);
const other = rankBrowserCandidate(
{ exePath: "/opt/google/chrome/chrome", explicitUserDataDir: "/tmp/somewhere-else" },
target,
);
const noFlag = rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome" }, target);
check(match > noFlag, "B2: exact user-data-dir match outranks a flagless process");
check(other < noFlag, "B2: a DIFFERENT explicit user-data-dir ranks below a flagless process");
check(other === 0, "B2: a different explicit dir is disqualified outright");
}
// B3: browser family match decides between flagless processes
{
const braveDir = join(homedir(), ".config/BraveSoftware/Brave-Browser");
const brave = rankBrowserCandidate({ exePath: "/usr/bin/brave-browser" }, braveDir);
const chrome = rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome" }, braveDir);
check(brave > chrome, "B3: Brave wins for a Brave user-data-dir");
const chromeDir = join(homedir(), ".config/google-chrome");
check(
rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome" }, chromeDir) >
rankBrowserCandidate({ exePath: "/usr/bin/brave-browser" }, chromeDir),
"B3: Chrome wins for a Chrome user-data-dir",
);
const chromiumDir = join(homedir(), ".config/chromium");
check(
rankBrowserCandidate({ exePath: "/usr/bin/chromium" }, chromiumDir) >
rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome" }, chromiumDir),
"B3: Chromium is not mistaken for Chrome",
);
}
// B4: no preference expressed → every candidate is equally acceptable
{
check(
rankBrowserCandidate({ exePath: "/usr/bin/brave-browser" }) ===
rankBrowserCandidate({ exePath: "/opt/google/chrome/chrome" }),
"B4: without a target dir, candidates rank equally",
);
}
// B5: Windows path comparison ignores case and separator style
if (process.platform === "win32") {
check(
rankBrowserCandidate(
{ exePath: "C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe", explicitUserDataDir: "C:\\Users\\U\\Data" },
"c:/users/u/data",
) === 4,
"B5 win: case and separator differences still match",
);
}
console.log(`\n${passed} passed, ${failed} failed`);
process.exit(failed === 0 ? 0 : 1);
}
main();
|
