aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 00:40:22 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commit1c73f4af643aa60ca554a3770264791d299e64e2 (patch)
treee1891349240438cb47b7ddde8f18f0762f4dcf79 /test
parente46f080c03a511b626b21455cfd6094554b02733 (diff)
fix(domains): stop fill_form misreporting select-by-label, let it fail
Three review fixes on the restored fill_form: - FILL_FN matches a <select> option by value, label or text but returns el.value, so filling by visible label ("Canada" -> value "ca") tripped the read-back mismatch check and reported a correctly-set field as "Filled 0/1 fields; issues: ref e4 (value mismatch)". The mismatch test now also accepts res.text, which FILL_FN sets only for selects, so mismatch detection is preserved for every other field kind. - fill_form always returned ok(), so total failure surfaced as a successful result reading "Filled 0/4 fields". It now returns invalid_state when okCount is 0, carrying the per-field issue list as the error message. Partial success stays ok(). - Removed the two comment blocks this task had added to test/manual/forms-test.ts. Neither behaviour fix has automated coverage; the manual suite that would exercise them still needs a live Chrome and was not run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'test')
-rw-r--r--test/manual/forms-test.ts8
1 files changed, 0 insertions, 8 deletions
diff --git a/test/manual/forms-test.ts b/test/manual/forms-test.ts
index 51c1600..ca6c596 100644
--- a/test/manual/forms-test.ts
+++ b/test/manual/forms-test.ts
@@ -15,12 +15,6 @@ import { createBrowserClient } from "../../src/client";
import { fillTool, selectOptionTool, setCheckedTool } from "../../src/domains/form";
import { fillFormTool } from "../../src/domains/form-batch";
-// NOTE: we intentionally do NOT import snapshotTool here — it pulls in pi-tui /
-// pi-coding-agent value imports that don't resolve under bare tsx. Instead we
-// publish an 'eN' ref map onto the session from Accessibility.getFullAXTree,
-// which is what browser_snapshot does when it prints [eN]. The snapshot's own
-// ref rendering is covered by `npm run typecheck` + the real-page smoke test.
-
let passed = 0;
let failed = 0;
const check = (cond: boolean, label: string): void => {
@@ -60,8 +54,6 @@ const FIXTURE = `
</script>
</body></html>`;
-// Publish an 'eN' ref map onto the session for the given accessible names and
-// return name → ref, mirroring what browser_snapshot does.
const publishRefs = async (client: any, names: ReadonlyArray<string>): Promise<Record<string, string | undefined>> => {
const ax = await client.session().call("Accessibility.getFullAXTree", {});
if (!ax.success) return {};