diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-28 22:08:16 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | b913f2d4af218ae61de7073778feb56da89a15de (patch) | |
| tree | d1c0f6796b3756563284c8edfd8be46a54e4f221 /test/manual | |
| parent | c88082515dcd9c0df1328b85420e97d7286ad428 (diff) | |
refactor: daemon internals, and fix a leak the merge exposed
IdMultiplexer and EventRouter were the only classes in src/; they are now
createIdMultiplexer/createEventRouter closures like every other factory
here. The multiplexer kept {clientId, localId} per daemon id while the
bridge kept {send, clientId, localId, timer, isAttach} under the same key
— two maps of overlapping data, and mux.resolve()'s return value was
discarded at three of four call sites. One map now holds the union.
That merge fixes a real leak: removeClient cleared the multiplexer but
never the callbacks map, so a disconnected client's timers stayed armed
and later fired a response at a socket that was gone. clearClient now
cancels them, and a test pins it.
handleRequest polled every 250ms for up to 15s per request when Chrome
was down; N queued requests now await one connect signal.
server.ts uses its own protocol's serialize/deserialize instead of
hand-rolled JSON, and broadcast no longer routes through `this` — the
only `this` in the codebase, and the one thing that breaks when the
server object is destructured.
cdp/event-queue.ts held two unrelated concerns; the request/timeout half
moves to cdp/pending-requests.ts. cdp/daemon-transport.ts is the client
half of the daemon protocol, so it moves to daemon/transport.ts.
test/daemon/ needs adding to the test glob to run at all — there was no
daemon test directory before because none of this was reachable without
live Chrome.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'test/manual')
| -rw-r--r-- | test/manual/daemon-transport-test.ts | 2 | ||||
| -rw-r--r-- | test/manual/e2e-test.ts | 2 | ||||
| -rw-r--r-- | test/manual/forms-test.ts | 2 | ||||
| -rw-r--r-- | test/manual/live-daemon-test.ts | 2 | ||||
| -rw-r--r-- | test/manual/profile-concurrency-test.ts | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/test/manual/daemon-transport-test.ts b/test/manual/daemon-transport-test.ts index 5738e23..30f5a29 100644 --- a/test/manual/daemon-transport-test.ts +++ b/test/manual/daemon-transport-test.ts @@ -1,5 +1,5 @@ import { createIpcServer } from "../../src/daemon/server"; -import { createDaemonTransport } from "../../src/cdp/daemon-transport"; +import { createDaemonTransport } from "../../src/daemon/transport"; import { DAEMON_SOCKET_PATH } from "../../src/daemon/protocol"; import type { WireMessage } from "../../src/daemon/protocol"; import { unlinkSync } from "node:fs"; diff --git a/test/manual/e2e-test.ts b/test/manual/e2e-test.ts index 81cb4df..02e04a4 100644 --- a/test/manual/e2e-test.ts +++ b/test/manual/e2e-test.ts @@ -1,6 +1,6 @@ import { createIpcServer } from "../../src/daemon/server"; import { createCdpBridge, type SendToClient } from "../../src/daemon/bridge"; -import { createDaemonTransport } from "../../src/cdp/daemon-transport"; +import { createDaemonTransport } from "../../src/daemon/transport"; import { DAEMON_SOCKET_PATH } from "../../src/daemon/protocol"; import type { WireRequest } from "../../src/daemon/protocol"; import { unlinkSync } from "node:fs"; diff --git a/test/manual/forms-test.ts b/test/manual/forms-test.ts index 43b2863..274f039 100644 --- a/test/manual/forms-test.ts +++ b/test/manual/forms-test.ts @@ -1,4 +1,4 @@ -import { createDaemonTransport } from "../../src/cdp/daemon-transport"; +import { createDaemonTransport } from "../../src/daemon/transport"; import { createBrowserClient } from "../../src/client"; import { fillTool, selectOptionTool, setCheckedTool } from "../../src/domains/form"; import { fillFormTool } from "../../src/domains/form-batch"; diff --git a/test/manual/live-daemon-test.ts b/test/manual/live-daemon-test.ts index 28ec7cd..5334cbc 100644 --- a/test/manual/live-daemon-test.ts +++ b/test/manual/live-daemon-test.ts @@ -1,4 +1,4 @@ -import { createDaemonTransport } from "../../src/cdp/daemon-transport"; +import { createDaemonTransport } from "../../src/daemon/transport"; async function main() { const t = createDaemonTransport("pi-live-test"); diff --git a/test/manual/profile-concurrency-test.ts b/test/manual/profile-concurrency-test.ts index 43cb880..83b233d 100644 --- a/test/manual/profile-concurrency-test.ts +++ b/test/manual/profile-concurrency-test.ts @@ -3,7 +3,7 @@ import { existsSync, mkdtempSync, rmSync } from "node:fs"; import { tmpdir } from "node:os"; import { join } from "node:path"; import { createBrowserClient } from "../../src/client"; -import { createDaemonTransport } from "../../src/cdp/daemon-transport"; +import { createDaemonTransport } from "../../src/daemon/transport"; import { isDaemonRunning, spawnDaemon } from "../../src/daemon/spawn"; import { closeIsolatedTab, openIsolatedTab } from "../../src/domains/isolated-tab"; |
