diff options
| author | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-06-21 00:46:44 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-06-21 00:46:44 +0530 |
| commit | da5d31af999b728c31ab0169373531cab4543f0c (patch) | |
| tree | 5d350ad1428ff332372a9c724ac46c964d8ca477 /test/manual/socket-guard-test.ts | |
| parent | 8db684d43366d335760e106eae39a74376bd7640 (diff) | |
release: v0.6.0 — per-tab isolation, Unix socket daemon, on-demand init (#6)
* feat: Unix socket daemon with auto-reconnect for persistent Chrome CDP
Eliminates the 'Allow Remote Debugging' Chrome prompt that appeared on
every pi session by multiplexing pi instances through a single persistent
daemon process.
Key additions:
- Unix socket IPC (net.createServer + readline JSON framing)
- CdpBridge with ID multiplexer + event router
- DaemonTransport implementing CdpTransport interface
- Auto-spawn with ensureDaemon() (lazy, checks socket)
Fixes since initial implementation:
- Bridge auto-reconnects to Chrome with exponential backoff (1s-60s).
Previously the bridge tried once at startup and permanently failed
if Chrome wasn't ready — causing 'Chrome not connected' on every
browser tool call.
- Daemon spawn uses project-local tsx binary instead of global --import
flag, fixing silent spawn failure (ERR_MODULE_NOT_FOUND).
- Stale ctx crash: persistState in onOwnershipChange wrapped in
try/catch to prevent CDP event consumer crashes.
49 test assertions across 4 test files. Zero TypeScript errors.
* feat: on-demand browser initialization
Browser daemon no longer auto-starts on session_start. Instead:
- session_start creates the client lazily but does NOT connect or spawn
the daemon. Zero Chrome prompts for non-browser pi sessions.
- Browser tool wrapper checks for daemon socket before each call.
Socket missing → clear error: 'Run /browser-setup first'.
Socket exists → proceeds silently (daemon already running).
- /browser-setup is the explicit, one-time init point. It spawns
the daemon and connects to Chrome only when the user opts in.
- SKILL.md updated with Connection Setup instructions telling agents
to direct users to /browser-setup when socket is missing.
* fix: checkChromeRunning on macOS — match by substring not exact
ps -A -o comm= returns full executable paths on modern macOS
(e.g. /Applications/Google Chrome.app/Contents/MacOS/Google Chrome),
not the basename. The old exact-match check (browserProcesses.includes(l))
never matched, causing false 'No browser instance running' errors.
Changed to substring includes() with helper/renderer/crashpad filtering.
* feat: browser_setup as agent-callable tool
The agent can now self-recover from 'Browser harness not initialized'
errors by calling browser_setup directly — no user mediation needed.
- Extracted shared performSetup() from the slash command into setup.ts
- Created src/domains/setup.ts with ensureAlive:false to bypass the
socket guard (this tool IS the setup, can't require itself)
- Registered browser_setup in the tool registry
- Updated SKILL.md: agent calls browser_setup directly, not ask user
- Removed stale test/manual/spawn-test.ts
* release: v0.6.0 — per-tab isolation, Unix socket daemon, on-demand init
Diffstat (limited to 'test/manual/socket-guard-test.ts')
| -rw-r--r-- | test/manual/socket-guard-test.ts | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/test/manual/socket-guard-test.ts b/test/manual/socket-guard-test.ts new file mode 100644 index 0000000..ab519f9 --- /dev/null +++ b/test/manual/socket-guard-test.ts @@ -0,0 +1,45 @@ +/** + * Test: socket guard produces clear error when daemon not running. + */ + +import { access } from "node:fs/promises"; +import { setTimeout as sleep } from "node:timers/promises"; +import { spawn } from "node:child_process"; +import { fileURLToPath } from "node:url"; +import { dirname, join } from "node:path"; +import { DAEMON_SOCKET_PATH } from "../../src/daemon/protocol"; + +async function main() { + const sock = DAEMON_SOCKET_PATH; + + // Simulate no daemon + try { + await access(sock); + console.log("FAIL: Socket exists unexpectedly"); + process.exit(1); + } catch { + console.log("✓ Socket missing — tool wrapper returns:"); + console.log(' "Browser harness not initialized. Run /browser-setup first"'); + } + + // Start daemon + const daemonEntry = join(dirname(fileURLToPath(import.meta.url)), "../../src/daemon/index.ts"); + const proc = spawn("npx", ["tsx", daemonEntry], { detached: true, stdio: "ignore" }); + proc.unref(); + await sleep(2000); + + // Now socket should exist + try { + await access(sock); + console.log("✓ Socket exists after daemon spawn — tool wrapper proceeds silently"); + } catch { + console.log("FAIL: Socket still missing after daemon spawn"); + process.exit(1); + } + + // Cleanup + proc.kill(); + console.log("✓ All socket guard checks passed"); +} + +main(); |
