diff options
| author | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-06-21 00:46:44 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-06-21 00:46:44 +0530 |
| commit | da5d31af999b728c31ab0169373531cab4543f0c (patch) | |
| tree | 5d350ad1428ff332372a9c724ac46c964d8ca477 /test/manual/ipc-server-test.ts | |
| parent | 8db684d43366d335760e106eae39a74376bd7640 (diff) | |
release: v0.6.0 — per-tab isolation, Unix socket daemon, on-demand init (#6)
* feat: Unix socket daemon with auto-reconnect for persistent Chrome CDP
Eliminates the 'Allow Remote Debugging' Chrome prompt that appeared on
every pi session by multiplexing pi instances through a single persistent
daemon process.
Key additions:
- Unix socket IPC (net.createServer + readline JSON framing)
- CdpBridge with ID multiplexer + event router
- DaemonTransport implementing CdpTransport interface
- Auto-spawn with ensureDaemon() (lazy, checks socket)
Fixes since initial implementation:
- Bridge auto-reconnects to Chrome with exponential backoff (1s-60s).
Previously the bridge tried once at startup and permanently failed
if Chrome wasn't ready — causing 'Chrome not connected' on every
browser tool call.
- Daemon spawn uses project-local tsx binary instead of global --import
flag, fixing silent spawn failure (ERR_MODULE_NOT_FOUND).
- Stale ctx crash: persistState in onOwnershipChange wrapped in
try/catch to prevent CDP event consumer crashes.
49 test assertions across 4 test files. Zero TypeScript errors.
* feat: on-demand browser initialization
Browser daemon no longer auto-starts on session_start. Instead:
- session_start creates the client lazily but does NOT connect or spawn
the daemon. Zero Chrome prompts for non-browser pi sessions.
- Browser tool wrapper checks for daemon socket before each call.
Socket missing → clear error: 'Run /browser-setup first'.
Socket exists → proceeds silently (daemon already running).
- /browser-setup is the explicit, one-time init point. It spawns
the daemon and connects to Chrome only when the user opts in.
- SKILL.md updated with Connection Setup instructions telling agents
to direct users to /browser-setup when socket is missing.
* fix: checkChromeRunning on macOS — match by substring not exact
ps -A -o comm= returns full executable paths on modern macOS
(e.g. /Applications/Google Chrome.app/Contents/MacOS/Google Chrome),
not the basename. The old exact-match check (browserProcesses.includes(l))
never matched, causing false 'No browser instance running' errors.
Changed to substring includes() with helper/renderer/crashpad filtering.
* feat: browser_setup as agent-callable tool
The agent can now self-recover from 'Browser harness not initialized'
errors by calling browser_setup directly — no user mediation needed.
- Extracted shared performSetup() from the slash command into setup.ts
- Created src/domains/setup.ts with ensureAlive:false to bypass the
socket guard (this tool IS the setup, can't require itself)
- Registered browser_setup in the tool registry
- Updated SKILL.md: agent calls browser_setup directly, not ask user
- Removed stale test/manual/spawn-test.ts
* release: v0.6.0 — per-tab isolation, Unix socket daemon, on-demand init
Diffstat (limited to 'test/manual/ipc-server-test.ts')
| -rw-r--r-- | test/manual/ipc-server-test.ts | 141 |
1 files changed, 141 insertions, 0 deletions
diff --git a/test/manual/ipc-server-test.ts b/test/manual/ipc-server-test.ts new file mode 100644 index 0000000..a267a45 --- /dev/null +++ b/test/manual/ipc-server-test.ts @@ -0,0 +1,141 @@ +/** + * Manual smoke test for IpcServer. + * Starts a server, connects a client, tests registration, send, broadcast, disconnect. + * Run: npx tsx test/manual/ipc-server-test.ts + */ +import { createConnection } from "node:net"; +import { createInterface } from "node:readline"; +import { createIpcServer } from "../../src/daemon/server"; +import { DAEMON_SOCKET_PATH } from "../../src/daemon/protocol"; +import type { WireMessage } from "../../src/daemon/protocol"; + +const TEST_CLIENT_ID = "pi-test-001"; + +async function main() { + let passed = 0; + let failed = 0; + const check = (cond: boolean, label: string) => { + if (cond) { passed++; console.log(` ✓ ${label}`); } + else { failed++; console.error(` ✗ ${label}`); } + }; + + // ── Start server ────────────────────────────────────────────────────── + console.log("Starting IpcServer..."); + const server = createIpcServer(); + + const receivedByServer: WireMessage[] = []; + let connectCount = 0; + let disconnectCount = 0; + + server.onMessage((msg) => { receivedByServer.push(msg); }); + server.onConnect(() => { connectCount++; }); + server.onDisconnect(() => { disconnectCount++; }); + + await server.start(); + console.log("Server started ✓"); + + // ── Connect client ──────────────────────────────────────────────────── + console.log("\nConnecting client..."); + const socket = createConnection(DAEMON_SOCKET_PATH); + const rl = createInterface({ input: socket, crlfDelay: Infinity }); + + const receivedByClient: WireMessage[] = []; + rl.on("line", (line) => { + try { receivedByClient.push(JSON.parse(line)); } catch { /* ignore */ } + }); + + await new Promise<void>((resolve) => socket.on("connect", resolve)); + console.log("Client connected ✓"); + + // ── Test 1: Registration ────────────────────────────────────────────── + // Send register, expect registered ack. + socket.write(JSON.stringify({ type: "control", action: "register", clientId: TEST_CLIENT_ID }) + "\n"); + await sleep(200); + + const ack = receivedByClient.find((m: any) => m.type === "control" && m.action === "registered"); + check(ack != null, "Registration acknowledged"); + check(connectCount === 1, "Connect handler fired"); + + // ── Test 2: Send message to server ──────────────────────────────────── + receivedByServer.length = 0; + const testRequest = { type: "request", id: 1, method: "Page.navigate", params: { url: "https://example.com" } }; + socket.write(JSON.stringify(testRequest) + "\n"); + await sleep(200); + + const received = receivedByServer.find((m: any) => m.type === "request" && m.id === 1); + check(received != null, "Server received request from client"); + check((received as any)?.method === "Page.navigate", "Method matches"); + + // ── Test 3: Server → client send ────────────────────────────────────── + receivedByClient.length = 0; + server.send(TEST_CLIENT_ID, { type: "response", id: 1, result: { frameId: "xyz" } }); + await sleep(200); + + const response = receivedByClient.find((m: any) => m.type === "response" && m.id === 1); + check(response != null, "Client received response from server"); + + // ── Test 4: Broadcast ───────────────────────────────────────────────── + receivedByClient.length = 0; + const broadcastMsg = { type: "event", method: "Target.targetCreated", params: { targetInfo: { type: "page" } } }; + server.broadcast(broadcastMsg); + await sleep(200); + + check(receivedByClient.length === 1, "Client received broadcast"); + const bc = receivedByClient[0] as any; + check(bc?.method === "Target.targetCreated", "Broadcast content matches"); + + // ── Test 5: Client disconnect ───────────────────────────────────────── + socket.destroy(); + await sleep(500); + + check(disconnectCount === 1, "Disconnect handler fired"); + check(server.clientCount() === 0, "Client count is 0 after disconnect"); + + // ── Test 6: Re-registration (same clientId after disconnect) ────────── + const socket2 = createConnection(DAEMON_SOCKET_PATH); + const rl2 = createInterface({ input: socket2, crlfDelay: Infinity }); + await new Promise<void>((resolve) => socket2.on("connect", resolve)); + + socket2.write(JSON.stringify({ type: "control", action: "register", clientId: TEST_CLIENT_ID }) + "\n"); + await sleep(200); + check(server.clientCount() === 1, "Re-registration works after disconnect"); + socket2.destroy(); + socket2.on("error", () => {}); // suppress EPIPE from server-side cleanup + await sleep(300); + + // ── Test 7: Max clients enforcement ─────────────────────────────────── + // Connect max clients, then one more should be rejected. + const testSockets: ReturnType<typeof createConnection>[] = []; + for (let i = 0; i < 20; i++) { + const s = createConnection(DAEMON_SOCKET_PATH); + s.on("error", () => {}); // server may reject and destroy this socket + testSockets.push(s); + await new Promise<void>((resolve) => s.on("connect", resolve)); + try { s.write(JSON.stringify({ type: "control", action: "register", clientId: `pi-test-max-${i}` }) + "\n"); } catch {} + await sleep(20); + } + await sleep(300); + check(server.clientCount() <= 16, "Max client enforcement works"); + // Clean up test sockets (some already destroyed by server rejection) + for (const s of testSockets) { + try { s.destroy(); } catch {} + s.removeAllListeners(); + } + + // ── Cleanup ─────────────────────────────────────────────────────────── + console.log(`\nCleaning up...`); + await server.stop(); + console.log("Server stopped ✓"); + + console.log(`\n${passed} passed, ${failed} failed`); + process.exit(failed > 0 ? 1 : 0); +} + +function sleep(ms: number): Promise<void> { + return new Promise((r) => setTimeout(r, ms)); +} + +main().catch((e) => { + console.error("Test failed:", e); + process.exit(1); +}); |
