diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-28 22:41:18 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | dcb79fc62bdd4d9ec0cbdb2c97d3eb2b2dacdf22 (patch) | |
| tree | 1b7d35ec51db118b06811aa72ea6cc36fdad948e /test/daemon/queue-test.ts | |
| parent | b484c017807acb902eaaaa4e242f8b79f8e8eba6 (diff) | |
refactor: merge nine files whose reason to exist was gone
src/ goes from 84 files to 75 at the same line count — every merge below
had exactly one consumer.
cdp/event-queue.ts and cdp/pending-requests.ts become daemon/queue.ts.
I split these in the daemon-internals commit on the grounds that they
held two unrelated concerns, but the transport commit had already deleted
the second transport, so both halves had one consumer and the split
bought nothing. They also sat in cdp/ while only daemon/ used them.
cdp/transport.ts held only the CdpTransport interface after the second
transport went; five of its six consumers import it type-only, so it
moves to cdp/types.ts. cdp/evaluate.ts moves into cdp/session.ts rather
than into its lone consumer isolated-tab.ts — it reaches session.call
directly, so under src/domains/ it would trip the raw-cdp-call rule.
util/keycodes.ts and util/time.ts fold into their only callers
(keyboard.ts, page.ts); util/bytes.ts into util/truncate.ts, which
already owns output-size formatting; readpage/capture.ts and
search/extract.ts into the tools beside them; profile/picker.ts into
profile/command.ts.
Kept deliberately: mutex.ts and domains/target.ts each have their own
test suite, and folding target.ts into click.ts would make a tool file
export a helper. sharp-shim.ts is an isolation boundary carrying two
allowlisted casts. result.ts, guards.ts, js-template.ts and paths.ts are
small but have 44, 12, 8 and 3 consumers.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'test/daemon/queue-test.ts')
| -rw-r--r-- | test/daemon/queue-test.ts | 136 |
1 files changed, 136 insertions, 0 deletions
diff --git a/test/daemon/queue-test.ts b/test/daemon/queue-test.ts new file mode 100644 index 0000000..6ea95f8 --- /dev/null +++ b/test/daemon/queue-test.ts @@ -0,0 +1,136 @@ +import { test, describe } from "node:test"; +import assert from "node:assert/strict"; +import { makeEventQueue, rejectAllPending, sendWithTimeout, type Pending } from "../../src/daemon/queue"; + +describe("event queue iteration", () => { + test("yields pushed events in order", async () => { + const q = makeEventQueue(); + q.push({ method: "Page.loadEventFired", params: {} }); + q.push({ method: "Page.frameNavigated", params: {} }); + const seen: string[] = []; + for await (const ev of q.iter) { + seen.push(ev.method); + if (seen.length === 2) break; + } + assert.deepEqual(seen, ["Page.loadEventFired", "Page.frameNavigated"]); + }); + + test("ending the queue terminates the iteration after draining the buffer", async () => { + const q = makeEventQueue(); + q.push({ method: "Page.loadEventFired", params: {} }); + q.end(); + const seen: string[] = []; + for await (const ev of q.iter) seen.push(ev.method); + assert.deepEqual(seen, ["Page.loadEventFired"]); + }); + + test("a waiter pending at end() is released", async () => { + const q = makeEventQueue(); + const done = (async () => { + const seen: string[] = []; + for await (const ev of q.iter) seen.push(ev.method); + return seen; + })(); + await Promise.resolve(); + q.end(); + assert.deepEqual(await done, []); + }); + + test("push after end() is dropped", async () => { + const q = makeEventQueue(); + q.end(); + q.push({ method: "Page.loadEventFired", params: {} }); + const seen: string[] = []; + for await (const ev of q.iter) seen.push(ev.method); + assert.deepEqual(seen, []); + }); + + test("a waiter is handed the next pushed event directly", async () => { + const q = makeEventQueue(); + const it = q.iter[Symbol.asyncIterator](); + const pending = it.next(); + await Promise.resolve(); + q.push({ method: "Runtime.consoleAPICalled", params: { a: 1 } }); + const r = await pending; + assert.equal(r.done, false); + assert.deepEqual(r.value, { method: "Runtime.consoleAPICalled", params: { a: 1 } }); + }); + + test("the terminal result reports done with an undefined value", async () => { + const q = makeEventQueue(); + q.end(); + const it = q.iter[Symbol.asyncIterator](); + const r = await it.next(); + assert.equal(r.done, true); + assert.equal(r.value, undefined); + }); + + test("sessionId is preserved on yielded events", async () => { + const q = makeEventQueue(); + q.push({ method: "Page.loadEventFired", params: {}, sessionId: "s1" }); + q.end(); + const seen: Array<string | undefined> = []; + for await (const ev of q.iter) seen.push(ev.sessionId); + assert.deepEqual(seen, ["s1"]); + }); +}); + +describe("pending request bookkeeping", () => { + test("rejectAllPending settles every entry with transport_closed and clears the map", () => { + const pending = new Map<number, Pending>(); + const settled: string[] = []; + for (const id of [1, 2]) { + pending.set(id, { + resolve: (r) => settled.push(r.success ? "ok" : r.error.kind), + timer: setTimeout(() => {}, 10_000), + method: `M.m${id}`, + }); + } + rejectAllPending(pending, "gone"); + assert.deepEqual(settled, ["transport_closed", "transport_closed"]); + assert.equal(pending.size, 0); + }); + + test("sendWithTimeout resolves transport_closed when send throws synchronously", async () => { + const pending = new Map<number, Pending>(); + const r = await sendWithTimeout(pending, 7, "M.m", 10_000, "Test", () => { + throw new Error("socket gone"); + }); + assert.equal(r.success, false); + if (!r.success) { + assert.equal(r.error.kind, "transport_closed"); + assert.equal(r.error.message, "socket gone"); + assert.equal(r.error.method, "M.m"); + } + assert.equal(pending.size, 0); + }); + + test("sendWithTimeout registers a pending entry the caller can resolve", async () => { + const pending = new Map<number, Pending>(); + let sent = false; + const p = sendWithTimeout(pending, 9, "M.m", 10_000, "Test", () => { + sent = true; + }); + assert.equal(sent, true); + const entry = pending.get(9); + assert.notEqual(entry, undefined); + if (entry) { + clearTimeout(entry.timer); + entry.resolve({ success: true, data: { hello: "world" } }); + } + const r = await p; + assert.equal(r.success, true); + if (r.success) assert.deepEqual(r.data, { hello: "world" }); + }); + + test("sendWithTimeout resolves a timeout error and drops the pending entry", async () => { + const pending = new Map<number, Pending>(); + const r = await sendWithTimeout(pending, 11, "M.slow", 1, "Test", () => {}); + assert.equal(r.success, false); + if (!r.success) { + assert.equal(r.error.kind, "timeout"); + assert.match(r.error.message, /Test timeout after 1ms: M\.slow/); + } + assert.equal(pending.size, 0); + }); +}); |
