aboutsummaryrefslogtreecommitdiff
path: root/src/util
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 00:01:32 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commit5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 (patch)
tree05720833665398725d960aad67496ff6159540eb /src/util
parent753c2ad615fa9827e168be256e1a7c7384605855 (diff)
refactor(tools): declare concurrency in the tool definition
serialized: true was applied in registry.ts, away from the tools it describes. Now a required concurrency field on each definition, with a test pinning the serialized set so the classes cannot drift. The lock check defaults to taking the mutex for any class that is not explicitly "parallel", so a definition that bypasses defineBrowserTool at runtime fails safe rather than racing on shared CDP state. The test script gains --conditions=import: pi-coding-agent publishes no "require" condition, so importing any tool definition from a CJS-loaded test could not resolve it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/util')
-rw-r--r--src/util/tool.ts11
1 files changed, 2 insertions, 9 deletions
diff --git a/src/util/tool.ts b/src/util/tool.ts
index 1e33c43..90a2e15 100644
--- a/src/util/tool.ts
+++ b/src/util/tool.ts
@@ -55,10 +55,7 @@ export type BrowserToolDefinition<S extends TSchema> = {
readonly handler: ToolHandler<S>;
readonly renderCall?: (args: Static<S>, theme: Theme) => Component;
readonly renderResult?: (result: AgentToolResult<unknown>, expanded: boolean, theme: Theme) => Component;
- /** If true, the tool acquires the client's mutation mutex before executing.
- * This ensures that two serialized tools never run concurrently,
- * preventing race conditions on shared CDP session/page state. */
- readonly serialized?: boolean;
+ readonly concurrency: "serialized" | "parallel";
readonly ensureAlive?: boolean;
};
@@ -169,12 +166,8 @@ export const registerBrowserTool = (
);
}
}
- // Serialized tools acquire the client's mutation mutex so that only one
- // mutation tool runs at a time. Observation tools skip this and run freely
- // in parallel. AbortSignal is checked after acquiring the lock so that a
- // cancelled task doesn't hold the mutex forever.
let release: (() => void) | undefined;
- if (def.serialized) {
+ if (def.concurrency !== "parallel") {
const acquire = await client.mutationMutex().acquire();
release = acquire;
if (signal?.aborted) {