diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-28 01:19:58 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae (patch) | |
| tree | 763ca6f879a693f56572ab256d33769d6d6bb0ad /src/util/sharp-shim.ts | |
| parent | b9c77bb6f9b8b83574489344ef6efd207a611e98 (diff) | |
refactor: close the remaining unguarded type assertions
Types the event-queue iterator's TReturn as undefined so the terminal
result needs no cast; declares the isError field the pi runtime reads by
duck-typing; binds socket to a local const in the daemon transport;
replaces the @ts-ignore on the optional sharp import with a non-literal
specifier so src/ still typechecks where sharp was not installed.
Adds src/util/guards.ts as the single home for narrowing over unknown —
isRecord plus scalar/array readers — and converts the two private
isObject copies in cdp/types.ts and daemon/protocol.ts along with every
inline `as Record<string, unknown>` in domains/js.ts and domains/render.ts.
Gives Accessibility.getFullAXTree a real result schema, closing the last
unvalidated CDP boundary: only nodeId is required, every object carries
additionalProperties, and each AX value stays Unknown, so the tree
decodes as a whole or fails as a whole rather than being filtered.
Guards the five tool-result `details` readers, the daemon attach
response, the persisted session state, the browser-namespace flag, and
the fs errno narrowing, each feeding an already-present failure path.
The daemon-transport socket binding is not a bug fix: send() runs
synchronously inside sendWithTimeout's promise executor, so socket cannot
be reassigned between the check and the write. It removes the assertion
and makes the write immune to a later refactor that adds an await.
Two assertions survive by design and are documented in the task report:
the never->unknown re-widening in util/tool.ts, which the type-erased
tool registry makes unavoidable, and the AsyncFunction constructor lookup
in domains/js.ts, which JavaScript exposes no typed binding for.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/util/sharp-shim.ts')
| -rw-r--r-- | src/util/sharp-shim.ts | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/util/sharp-shim.ts b/src/util/sharp-shim.ts index a9f145e..36dd536 100644 --- a/src/util/sharp-shim.ts +++ b/src/util/sharp-shim.ts @@ -20,21 +20,21 @@ export type SharpLoad = | { readonly kind: "missing" } | { readonly kind: "error"; readonly message: string }; +const SHARP_SPECIFIER: string = "sharp"; + +const MISSING_MODULE_MARKERS: ReadonlyArray<string> = [ + "Cannot find module", + "MODULE_NOT_FOUND", + "ERR_MODULE_NOT_FOUND", +]; + export const loadSharp = async (): Promise<SharpLoad> => { let mod: unknown; try { - // sharp is an optional dependency; it may not be installed. - // @ts-ignore — optional peer dependency not required at compile time - mod = await import("sharp"); + mod = await import(SHARP_SPECIFIER); } catch (e) { const msg = e instanceof Error ? e.message : String(e); - if ( - msg.includes("Cannot find module") || - msg.includes("MODULE_NOT_FOUND") || - msg.includes("ERR_MODULE_NOT_FOUND") - ) { - return { kind: "missing" }; - } + if (MISSING_MODULE_MARKERS.some((marker) => msg.includes(marker))) return { kind: "missing" }; return { kind: "error", message: msg }; } if (mod === null || mod === undefined) return { kind: "missing" }; |
