diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-28 01:19:58 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae (patch) | |
| tree | 763ca6f879a693f56572ab256d33769d6d6bb0ad /src/util/guards.ts | |
| parent | b9c77bb6f9b8b83574489344ef6efd207a611e98 (diff) | |
refactor: close the remaining unguarded type assertions
Types the event-queue iterator's TReturn as undefined so the terminal
result needs no cast; declares the isError field the pi runtime reads by
duck-typing; binds socket to a local const in the daemon transport;
replaces the @ts-ignore on the optional sharp import with a non-literal
specifier so src/ still typechecks where sharp was not installed.
Adds src/util/guards.ts as the single home for narrowing over unknown —
isRecord plus scalar/array readers — and converts the two private
isObject copies in cdp/types.ts and daemon/protocol.ts along with every
inline `as Record<string, unknown>` in domains/js.ts and domains/render.ts.
Gives Accessibility.getFullAXTree a real result schema, closing the last
unvalidated CDP boundary: only nodeId is required, every object carries
additionalProperties, and each AX value stays Unknown, so the tree
decodes as a whole or fails as a whole rather than being filtered.
Guards the five tool-result `details` readers, the daemon attach
response, the persisted session state, the browser-namespace flag, and
the fs errno narrowing, each feeding an already-present failure path.
The daemon-transport socket binding is not a bug fix: send() runs
synchronously inside sendWithTimeout's promise executor, so socket cannot
be reassigned between the check and the write. It removes the assertion
and makes the write immune to a later refactor that adds an await.
Two assertions survive by design and are documented in the task report:
the never->unknown re-widening in util/tool.ts, which the type-erased
tool registry makes unavoidable, and the AsyncFunction constructor lookup
in domains/js.ts, which JavaScript exposes no typed binding for.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/util/guards.ts')
| -rw-r--r-- | src/util/guards.ts | 30 |
1 files changed, 30 insertions, 0 deletions
diff --git a/src/util/guards.ts b/src/util/guards.ts new file mode 100644 index 0000000..2744c68 --- /dev/null +++ b/src/util/guards.ts @@ -0,0 +1,30 @@ +export const isRecord = (v: unknown): v is Readonly<Record<string, unknown>> => + typeof v === "object" && v !== null && !Array.isArray(v); + +export const asRecord = (v: unknown): Readonly<Record<string, unknown>> | undefined => + isRecord(v) ? v : undefined; + +export const asString = (v: unknown): string | undefined => (typeof v === "string" ? v : undefined); + +export const asNumber = (v: unknown): number | undefined => (typeof v === "number" ? v : undefined); + +export const asBoolean = (v: unknown): boolean | undefined => (typeof v === "boolean" ? v : undefined); + +export const asArrayOf = <T>( + v: unknown, + item: (x: unknown) => T | undefined, +): ReadonlyArray<T> | undefined => { + if (!Array.isArray(v)) return undefined; + const out: T[] = []; + for (const x of v) { + const parsed = item(x); + if (parsed === undefined) return undefined; + out.push(parsed); + } + return out; +}; + +export const errnoCode = (e: unknown): string | undefined => { + if (!(e instanceof Error) || !("code" in e)) return undefined; + return asString(e.code); +}; |
