diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-28 00:01:32 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | 5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 (patch) | |
| tree | 05720833665398725d960aad67496ff6159540eb /src/registry.ts | |
| parent | 753c2ad615fa9827e168be256e1a7c7384605855 (diff) | |
refactor(tools): declare concurrency in the tool definition
serialized: true was applied in registry.ts, away from the tools it
describes. Now a required concurrency field on each definition, with a
test pinning the serialized set so the classes cannot drift.
The lock check defaults to taking the mutex for any class that is not
explicitly "parallel", so a definition that bypasses defineBrowserTool at
runtime fails safe rather than racing on shared CDP state.
The test script gains --conditions=import: pi-coding-agent publishes no
"require" condition, so importing any tool definition from a CJS-loaded
test could not resolve it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/registry.ts')
| -rw-r--r-- | src/registry.ts | 58 |
1 files changed, 26 insertions, 32 deletions
diff --git a/src/registry.ts b/src/registry.ts index a063c9f..8301d29 100644 --- a/src/registry.ts +++ b/src/registry.ts @@ -22,53 +22,47 @@ import { setupTool } from "./domains/setup"; import { webSearchTool } from "./domains/search/web-search"; import { readPageTool } from "./domains/readpage/read-page"; -// Mutation tools that modify page / browser state are marked `serialized: true` -// so they run through a shared async mutex. Observation / read-only tools are -// left unmarked and can execute in parallel. -const TOOLS: ReadonlyArray<AnyBrowserToolDefinition> = [ - // setup comes first — the agent calls this to self-recover from not-initialized +export const ALL_TOOLS: ReadonlyArray<AnyBrowserToolDefinition> = [ setupTool, - { ...clickTool, serialized: true }, - { ...typeTool, serialized: true }, - { ...fillTool, serialized: true }, - { ...selectOptionTool, serialized: true }, - { ...focusTool, serialized: true }, - { ...pressKeyTool, serialized: true }, - { ...dispatchKeyTool, serialized: true }, - { ...scrollTool, serialized: true }, + clickTool, + typeTool, + fillTool, + selectOptionTool, + focusTool, + pressKeyTool, + dispatchKeyTool, + scrollTool, pageInfoTool, waitTool, waitForTool, - { ...waitForLoadTool, serialized: true }, - { ...handleDialogTool, serialized: true }, + waitForLoadTool, + handleDialogTool, screenshotTool, - { ...navigateTool, serialized: true }, - { ...openUrlsTool, serialized: true }, - { ...goBackTool, serialized: true }, - { ...goForwardTool, serialized: true }, - { ...reloadTool, serialized: true }, + navigateTool, + openUrlsTool, + goBackTool, + goForwardTool, + reloadTool, listTabsTool, currentTabTool, - { ...switchTabTool, serialized: true }, - { ...newTabTool, serialized: true }, - { ...closeTabTool, serialized: true }, - { ...uploadFileTool, serialized: true }, - { ...downloadTool, serialized: true }, - { ...printToPdfTool, serialized: true }, - { ...viewportResizeTool, serialized: true }, - { ...dragAndDropTool, serialized: true }, + switchTabTool, + newTabTool, + closeTabTool, + uploadFileTool, + downloadTool, + printToPdfTool, + viewportResizeTool, + dragAndDropTool, httpGetTool, networkRequestsTool, consoleTool, snapshotTool, executeJsTool, runScriptTool, - // Opens and owns an isolated tab to scrape a SERP — same class as openUrlsTool. - { ...webSearchTool, serialized: true }, - // Pure isolated read (own sessionId, own tab) — safe concurrent, like executeJsTool. + webSearchTool, readPageTool, ]; export const registerAllTools = (pi: ExtensionAPI, client: BrowserClient): void => { - for (const t of TOOLS) registerBrowserTool(pi, client, t); + for (const t of ALL_TOOLS) registerBrowserTool(pi, client, t); }; |
