diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-27 23:26:50 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | 9f2f75dd9281153888776e5d39d4926655c15f2a (patch) | |
| tree | 89c23c8ad333b5096d39b661b142eaad544cf004 /src/domains/tabs.ts | |
| parent | 931576443dcb990761cb7e68e354465145f9292d (diff) | |
refactor(domains): drop CDP casts, share the box-model unwrap
ref-resolve.ts and snapshot.ts had the same box-model unwrap, both using
data.model! to work around an untyped response. Extracted to domains/box.ts;
the typed schema makes the assertions unnecessary. Both derived the centre
identically (quad corner + half the model width/height), so centreOf keeps
that derivation; the shared zero-size rejection moved into boxOf, and
snapshot keeps its own off-viewport (x/y < 0) filter.
evalInIsolatedTab now goes through evaluateJson with the tab's own sessionId
and a caller-supplied guard; both callers evaluate expressions ending in
JSON.stringify, so they pass isJsonText rather than a check that checks
nothing. Runtime.evaluate/callFunctionOn result casts in form.ts, forms.ts
and keyboard.ts are replaced by named guards over the in-page result shapes.
Runtime.callFunctionOn's params schema gained arguments/returnByValue/
awaitPromise/userGesture: four domain call sites legitimately pass them and
typebox's additionalProperties:true does not widen the static type, so the
params type was rejecting valid CDP fields. Params schemas are type-only
(only results are compiled), so this is a compile-time widening with no
runtime effect.
tsc is green again for both tsconfigs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/tabs.ts')
| -rw-r--r-- | src/domains/tabs.ts | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/domains/tabs.ts b/src/domains/tabs.ts index f706100..e3e2623 100644 --- a/src/domains/tabs.ts +++ b/src/domains/tabs.ts @@ -55,7 +55,7 @@ export const currentTabTool = defineBrowserTool({ if (!cur) return err({ kind: "invalid_state", message: "No tab attached." }); const ti = await client.session().callBrowser("Target.getTargetInfo", { targetId: cur.targetId }); if (!ti.success) return err({ kind: "cdp_error", message: ti.error.message }); - const info = (ti.data as { targetInfo: { targetId: string; url: string; title: string } }).targetInfo; // CDP boundary cast: Target.getTargetInfo returns { targetInfo: { targetId, url, title } } + const info = ti.data.targetInfo; const owned = client.owns(info.targetId); return ok({ text: `Current tab${owned ? " (owned)" : " (NOT owned by this session)"}:\n ${info.targetId}\n ${info.url}\n ${info.title}`, @@ -104,7 +104,9 @@ export const switchTabTool = defineBrowserTool({ details: { matches: matches.map((t) => ({ targetId: t.targetId, url: t.url })) }, }); } - resolved = matches[0]!.targetId; + const first = matches[0]; + if (first === undefined) return err({ kind: "invalid_state", message: "no matching tab" }); + resolved = first.targetId; } if (!client.owns(resolved)) { return err({ @@ -172,7 +174,8 @@ export const closeTabTool = defineBrowserTool({ if (isHexPrefix) { const owned = client.ownership().list(); const matches = owned.filter((id) => id.startsWith(args.targetId)); - if (matches.length === 1) resolved = matches[0]!; + const first = matches[0]; + if (matches.length === 1 && first !== undefined) resolved = first; else if (matches.length > 1) { return err({ kind: "invalid_state", |
