diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-27 23:26:50 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | 9f2f75dd9281153888776e5d39d4926655c15f2a (patch) | |
| tree | 89c23c8ad333b5096d39b661b142eaad544cf004 /src/domains/screenshot.ts | |
| parent | 931576443dcb990761cb7e68e354465145f9292d (diff) | |
refactor(domains): drop CDP casts, share the box-model unwrap
ref-resolve.ts and snapshot.ts had the same box-model unwrap, both using
data.model! to work around an untyped response. Extracted to domains/box.ts;
the typed schema makes the assertions unnecessary. Both derived the centre
identically (quad corner + half the model width/height), so centreOf keeps
that derivation; the shared zero-size rejection moved into boxOf, and
snapshot keeps its own off-viewport (x/y < 0) filter.
evalInIsolatedTab now goes through evaluateJson with the tab's own sessionId
and a caller-supplied guard; both callers evaluate expressions ending in
JSON.stringify, so they pass isJsonText rather than a check that checks
nothing. Runtime.evaluate/callFunctionOn result casts in form.ts, forms.ts
and keyboard.ts are replaced by named guards over the in-page result shapes.
Runtime.callFunctionOn's params schema gained arguments/returnByValue/
awaitPromise/userGesture: four domain call sites legitimately pass them and
typebox's additionalProperties:true does not widen the static type, so the
params type was rejecting valid CDP fields. Params schemas are type-only
(only results are compiled), so this is a compile-time widening with no
runtime effect.
tsc is green again for both tsconfigs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/screenshot.ts')
| -rw-r--r-- | src/domains/screenshot.ts | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/domains/screenshot.ts b/src/domains/screenshot.ts index 9d6313b..a30d336 100644 --- a/src/domains/screenshot.ts +++ b/src/domains/screenshot.ts @@ -29,13 +29,13 @@ const captureBase = async ( const format = args.format ?? "png"; const quality = args.quality ?? 80; const path = screenshotPath(client.namespace, format); - const params: Record<string, unknown> = { format, captureBeyondViewport: args.fullPage ?? false }; - if (format === "jpeg") params["quality"] = quality; - const r = await client.session().call("Page.captureScreenshot", params); + const r = await client.session().call("Page.captureScreenshot", { + format, + captureBeyondViewport: args.fullPage ?? false, + ...(format === "jpeg" ? { quality } : {}), + }); if (!r.success) return err({ kind: "cdp_error", message: r.error.message }); - // Page.captureScreenshot returns { data: base64 } - const data = (r.data as { data: string }).data; - await writeFile(path, Buffer.from(data, "base64")); + await writeFile(path, Buffer.from(r.data.data, "base64")); return ok({ path, format }); }; |
