aboutsummaryrefslogtreecommitdiff
path: root/src/domains/screenshot.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 21:55:55 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commit632600ec0a0a68d9327e19bd419a1ae72047955f (patch)
tree5ef59b561d055b8f9173154c252e6d464f3a042b /src/domains/screenshot.ts
parent893a9d338ceb5d37aefece1df637c9a5888a120e (diff)
refactor: one door from a tool to the browser
Four routes coexisted: cdpCall, a raw client.session().call, a session held in a local and called directly, and client.evaluateJs — and five files mixed two or three of them. The CdpError-to-ToolErr mapping was hand-copied at nine sites, plus a private copy in isolated-tab.ts. domains/cdp-call.ts now owns all of it: cdpErrToToolErr, cdpCall, cdpCallOnTarget, cdpCallBrowser, evalJs. Every other file under src/domains goes through them, which also removes a pile of `if (!r.success) return err({ kind: "cdp_error", ... })` boilerplate in favour of returning the failed Result as-is. Two scanner rules keep it that way, scoped to src/domains/ so the layer that legitimately owns the session — cdp/ and client.ts — is unaffected. Scoping is new to the rule model; without it the rules fired on the transport itself. One deliberate behaviour change: a CDP timeout now surfaces as kind "timeout" rather than "cdp_error". isolated-tab.ts already did this and the other 13 sites flattened it; the shared mapper uses the honest label rather than preserving the mislabel. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/screenshot.ts')
-rw-r--r--src/domains/screenshot.ts4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/domains/screenshot.ts b/src/domains/screenshot.ts
index 04f0fa9..4b5732d 100644
--- a/src/domains/screenshot.ts
+++ b/src/domains/screenshot.ts
@@ -9,7 +9,7 @@ import { screenshotPath } from "../util/paths";
import { loadSharp } from "../util/sharp-shim";
import { asRecord, asString } from "../util/guards";
import { safeJs } from "../util/js-template";
-import { cdpCall } from "./cdp-call";
+import { cdpCall, evalJs } from "./cdp-call";
const ScreenshotArgs = Type.Object({
fullPage: Type.Optional(Type.Boolean({ default: false, description: "Capture beyond viewport" })),
@@ -133,7 +133,7 @@ export const captureWithCrosshair = async (
const load = await loadSharp();
if (load.kind !== "ok") return ok({ path: cap.data.path });
try {
- const dprR = await client.evaluateJs(safeJs`window.devicePixelRatio`);
+ const dprR = await evalJs(client, safeJs`window.devicePixelRatio`);
const dpr = dprR.success && typeof dprR.data === "number" ? dprR.data : 1;
const meta = await load.sharp(cap.data.path).metadata();
const w = meta.width ?? 0;