aboutsummaryrefslogtreecommitdiff
path: root/src/domains/navigate.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 00:17:13 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commitbfba73fa2f1373abd8a5a704c9c833d6fce1b44f (patch)
treee684310863ef6d9aaa9a6bd3d4d3100d75ee9069 /src/domains/navigate.ts
parent5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 (diff)
refactor(domains): share target resolution and CDP error mapping
The ref-vs-x/y branch turned out to exist in one tool, not four; it is now one helper with tests covering the half-specified-coordinate and stale-ref cases. cdpCall folds the repeated cdp_error mapping at 24 active-session call sites; target-scoped callOnTarget/callBrowser sites are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/navigate.ts')
-rw-r--r--src/domains/navigate.ts5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/domains/navigate.ts b/src/domains/navigate.ts
index ba86751..93c6a89 100644
--- a/src/domains/navigate.ts
+++ b/src/domains/navigate.ts
@@ -6,6 +6,7 @@ import { applyTruncation } from "../util/truncate";
import { safeJs } from "../util/js-template";
import { attachTo } from "../cdp/attach";
import { ensureHarnessWindow, openHarnessTab } from "../cdp/target-factory";
+import { cdpCall } from "./cdp-call";
const NavigateArgs = Type.Object({
url: Type.String({ description: "Full URL to navigate to (e.g. https://github.com)" }),
@@ -39,8 +40,8 @@ export const navigateTool = defineBrowserTool({
if (!created.success) return err({ kind: "cdp_error", message: created.error.message });
outcome = { kind: "new_tab_created", targetId: created.data, reason: "no_tabs" };
} else {
- const nav = await client.session().call("Page.navigate", { url: args.url });
- if (!nav.success) return err({ kind: "cdp_error", message: nav.error.message });
+ const nav = await cdpCall(client, "Page.navigate", { url: args.url });
+ if (!nav.success) return nav;
const cur = client.current();
if (!cur) return err({ kind: "internal", message: "navigate succeeded but no current target tracked" });
outcome = { kind: "in_place", targetId: cur.targetId };