aboutsummaryrefslogtreecommitdiff
path: root/src/domains/form.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 00:17:13 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commitbfba73fa2f1373abd8a5a704c9c833d6fce1b44f (patch)
treee684310863ef6d9aaa9a6bd3d4d3100d75ee9069 /src/domains/form.ts
parent5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 (diff)
refactor(domains): share target resolution and CDP error mapping
The ref-vs-x/y branch turned out to exist in one tool, not four; it is now one helper with tests covering the half-specified-coordinate and stale-ref cases. cdpCall folds the repeated cdp_error mapping at 24 active-session call sites; target-scoped callOnTarget/callBrowser sites are left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/form.ts')
-rw-r--r--src/domains/form.ts5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/domains/form.ts b/src/domains/form.ts
index 6e3285a..a1ae7f5 100644
--- a/src/domains/form.ts
+++ b/src/domains/form.ts
@@ -3,6 +3,7 @@ import type { BrowserClient } from "../client";
import { safeJs } from "../util/js-template";
import { type Result, err, ok } from "../util/result";
import { defineBrowserTool, type ToolErr, type ToolOk } from "../util/tool";
+import { cdpCall } from "./cdp-call";
import { interactiveDiff, resolveRefToObjectId } from "./ref-resolve";
const FillArgs = Type.Object({
@@ -33,13 +34,13 @@ const runOnElement = async (
if (opts.ref !== undefined) {
const objectId = await resolveRefToObjectId(client, opts.ref);
if (!objectId.success) return objectId;
- const r = await client.session().call("Runtime.callFunctionOn", {
+ const r = await cdpCall(client, "Runtime.callFunctionOn", {
objectId: objectId.data,
functionDeclaration: `function (arg) { ${opts.fnBody} }`,
arguments: [{ value: opts.arg }],
returnByValue: true,
});
- if (!r.success) return err({ kind: "cdp_error", message: r.error.message });
+ if (!r.success) return r;
return ok(r.data.result.value);
}
if (opts.selector === undefined) {