aboutsummaryrefslogtreecommitdiff
path: root/src/domains/dialog.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-27 23:26:50 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commit9f2f75dd9281153888776e5d39d4926655c15f2a (patch)
tree89c23c8ad333b5096d39b661b142eaad544cf004 /src/domains/dialog.ts
parent931576443dcb990761cb7e68e354465145f9292d (diff)
refactor(domains): drop CDP casts, share the box-model unwrap
ref-resolve.ts and snapshot.ts had the same box-model unwrap, both using data.model! to work around an untyped response. Extracted to domains/box.ts; the typed schema makes the assertions unnecessary. Both derived the centre identically (quad corner + half the model width/height), so centreOf keeps that derivation; the shared zero-size rejection moved into boxOf, and snapshot keeps its own off-viewport (x/y < 0) filter. evalInIsolatedTab now goes through evaluateJson with the tab's own sessionId and a caller-supplied guard; both callers evaluate expressions ending in JSON.stringify, so they pass isJsonText rather than a check that checks nothing. Runtime.evaluate/callFunctionOn result casts in form.ts, forms.ts and keyboard.ts are replaced by named guards over the in-page result shapes. Runtime.callFunctionOn's params schema gained arguments/returnByValue/ awaitPromise/userGesture: four domain call sites legitimately pass them and typebox's additionalProperties:true does not widen the static type, so the params type was rejecting valid CDP fields. Params schemas are type-only (only results are compiled), so this is a compile-time widening with no runtime effect. tsc is green again for both tsconfigs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/domains/dialog.ts')
-rw-r--r--src/domains/dialog.ts7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/domains/dialog.ts b/src/domains/dialog.ts
index a5872a1..c30e70c 100644
--- a/src/domains/dialog.ts
+++ b/src/domains/dialog.ts
@@ -19,9 +19,10 @@ export const handleDialogTool = defineBrowserTool({
],
parameters: HandleDialogArgs,
async handler(args, { client }): Promise<Result<ToolOk, ToolErr>> {
- const params: Record<string, unknown> = { accept: args.accept };
- if (args.promptText !== undefined) params["promptText"] = args.promptText;
- const r = await client.session().call("Page.handleJavaScriptDialog", params);
+ const r = await client.session().call("Page.handleJavaScriptDialog", {
+ accept: args.accept,
+ ...(args.promptText !== undefined ? { promptText: args.promptText } : {}),
+ });
if (!r.success) return err({ kind: "cdp_error", message: r.error.message });
return ok({
text: `Dialog ${args.accept ? "accepted" : "dismissed"}`,