aboutsummaryrefslogtreecommitdiff
path: root/src/daemon/bridge.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmail.com>2026-07-28 00:53:19 +0530
committerAman Kumar <145339995+amankumarsingh77@users.noreply.github.com>2026-08-02 19:12:46 +0530
commitb9c77bb6f9b8b83574489344ef6efd207a611e98 (patch)
tree3c59bf53bcce3ac5c6bbf9a22884b6e6f787dc91 /src/daemon/bridge.ts
parent1c73f4af643aa60ca554a3770264791d299e64e2 (diff)
refactor: validate JSON at every parse boundary
Ten sites cast or implicitly typed JSON.parse output; JSON.parse("null") would have satisfied all of them. parseJson returns a Result and validates against a typebox schema. js.ts keeps unknown — user script output has no fixed shape. daemon/bridge.ts assigned JSON.parse straight to CdpRawMessage with no guard at all; it now uses isCdpRawMessage like the transport does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/daemon/bridge.ts')
-rw-r--r--src/daemon/bridge.ts7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/daemon/bridge.ts b/src/daemon/bridge.ts
index 33ef63b..de6dec7 100644
--- a/src/daemon/bridge.ts
+++ b/src/daemon/bridge.ts
@@ -12,6 +12,7 @@
import WebSocket from "ws";
import { discoverWsUrl } from "../cdp/discovery";
+import { isCdpRawMessage } from "../cdp/types";
import type { CdpRawMessage } from "../cdp/types";
import type { WireRequest, WireResponse, WireEvent } from "./protocol";
import { CDP_CONNECT_TIMEOUT_MS, CDP_COMMAND_TIMEOUT_MS } from "./protocol";
@@ -150,8 +151,10 @@ export const createCdpBridge = (): CdpBridge => {
// ── Handle raw CDP messages from Chrome ─────────────────────────────────
const onChromeMessage = (raw: string): void => {
- let msg: CdpRawMessage;
- try { msg = JSON.parse(raw); } catch { return; }
+ let parsed: unknown;
+ try { parsed = JSON.parse(raw); } catch { return; }
+ if (!isCdpRawMessage(parsed)) return;
+ const msg: CdpRawMessage = parsed;
// ---- Response (has id) ----
if (msg.id !== undefined) {