aboutsummaryrefslogtreecommitdiff
path: root/src/client.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmal.com>2026-05-02 16:53:34 +0530
committeramankumarsingh77 <amankumarsingh7702@gmal.com>2026-05-02 16:53:34 +0530
commitc9d1605b1e3b8dbe88cd3674a9256aa0465f3e6d (patch)
treef14e155a6615fb2d7aca27642ec44463aeb2b18c /src/client.ts
parent500dd206d300ab39599021ef9e80ed30d1871b9a (diff)
chore: address final-review minors — surface event-consumer crashes, document IIFE-wrap heuristic, log shutdown failures, fix CHANGELOG file-size claim
Five tweaks from the whole-implementation review: - session.ts: log unexpected event-consumer rejections instead of silent swallow - client.ts: comment the return-substring IIFE-wrap false-positive case - transport.ts: comment that ws.onclose post-open settle is no-op-by-design - index.ts: log client.stop() failures during shutdown - CHANGELOG.md: correct largest-file claim (transport.ts and client.ts are ~220 each, not "client.ts at ~180") Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/client.ts')
-rw-r--r--src/client.ts4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/client.ts b/src/client.ts
index 1fcef67..51dfa9f 100644
--- a/src/client.ts
+++ b/src/client.ts
@@ -117,6 +117,10 @@ export const createBrowserClient = (opts: BrowserClientOptions): BrowserClient =
};
const evaluateJs = async (expression: string, sessionId?: string): Promise<Result<unknown, CdpError>> => {
+ // Heuristic IIFE wrap: legacy convenience that lets agents write
+ // `return foo` instead of `(() => foo)()`. False-positive on substring
+ // `"return "` inside string literals or comments — agents that hit this
+ // can pass an explicit IIFE instead.
const wrapped = expression.includes("return ") && !expression.trim().startsWith("(")
? `(function(){${expression}})()`
: expression;