aboutsummaryrefslogtreecommitdiff
path: root/src/cdp/session.ts
diff options
context:
space:
mode:
authoramankumarsingh77 <amankumarsingh7702@gmal.com>2026-05-02 16:53:34 +0530
committeramankumarsingh77 <amankumarsingh7702@gmal.com>2026-05-02 16:53:34 +0530
commitc9d1605b1e3b8dbe88cd3674a9256aa0465f3e6d (patch)
treef14e155a6615fb2d7aca27642ec44463aeb2b18c /src/cdp/session.ts
parent500dd206d300ab39599021ef9e80ed30d1871b9a (diff)
chore: address final-review minors — surface event-consumer crashes, document IIFE-wrap heuristic, log shutdown failures, fix CHANGELOG file-size claim
Five tweaks from the whole-implementation review: - session.ts: log unexpected event-consumer rejections instead of silent swallow - client.ts: comment the return-substring IIFE-wrap false-positive case - transport.ts: comment that ws.onclose post-open settle is no-op-by-design - index.ts: log client.stop() failures during shutdown - CHANGELOG.md: correct largest-file claim (transport.ts and client.ts are ~220 each, not "client.ts at ~180") Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/cdp/session.ts')
-rw-r--r--src/cdp/session.ts8
1 files changed, 7 insertions, 1 deletions
diff --git a/src/cdp/session.ts b/src/cdp/session.ts
index fffa241..b1ae71c 100644
--- a/src/cdp/session.ts
+++ b/src/cdp/session.ts
@@ -45,7 +45,13 @@ export const createCdpSession = (transport: CdpTransport): CdpSession => {
};
const restartConsumer = (): void => {
- activeConsumer = activeConsumer.then(() => consumeEvents()).catch(() => undefined);
+ activeConsumer = activeConsumer.then(() => consumeEvents()).catch((e: unknown) => {
+ // The .then() chain calls consumeEvents() which iterates the transport's
+ // events() AsyncIterable. The iterable resolves cleanly on close (returns
+ // {done:true}); any rejection here is an unexpected bug in the event
+ // handler, not a normal termination. Surface it on stderr so it's not lost.
+ console.warn("[pi-browser-harness] CDP event consumer crashed:", e);
+ });
};
restartConsumer();