diff options
| author | amankumarsingh77 <amankumarsingh7702@gmail.com> | 2026-07-27 00:48:45 +0530 |
|---|---|---|
| committer | Aman Kumar <145339995+amankumarsingh77@users.noreply.github.com> | 2026-08-02 19:12:46 +0530 |
| commit | 9f2ef1cf87251ce12f6b6432c48c6e7d2017b6b5 (patch) | |
| tree | 2fad3353b016a9a35a049a7250b58ab2d165b50e /src/cdp/commands.ts | |
| parent | ae3a6dcdbe584a9131a514ea3d738abaec6460f3 (diff) | |
refactor(cdp): make session.call generic over the command table
call/callOnTarget/callBrowser now take a known method and return its
decoded result type. The session is where unknown ends; transport keeps
returning unknown. Removes the casts in session.ts and target-factory.ts,
including the session's own internal Target.*/Browser.* calls, which now
decode through the same path as the public call methods.
Also completes two params-schema gaps in commands.ts surfaced by this
migration: Target.createTarget was missing openerId and Runtime.evaluate
was missing userGesture, both real CDP fields src/cdp/ already sends.
tsc is red project-wide (6 errors, all in src/domains/) — the sanctioned
state between Tasks 4 and 7.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'src/cdp/commands.ts')
| -rw-r--r-- | src/cdp/commands.ts | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/cdp/commands.ts b/src/cdp/commands.ts index 123b9f6..d7faa34 100644 --- a/src/cdp/commands.ts +++ b/src/cdp/commands.ts @@ -57,6 +57,7 @@ export const COMMANDS = { newWindow: Type.Optional(Type.Boolean()), background: Type.Optional(Type.Boolean()), windowId: Type.Optional(Type.Number()), + openerId: Type.Optional(Type.String()), }), Type.Object({ targetId: Type.String() }), ), @@ -129,7 +130,12 @@ export const COMMANDS = { // --- Runtime --- "Runtime.evaluate": cmd( Type.Object( - { expression: Type.String(), returnByValue: Type.Optional(Type.Boolean()), awaitPromise: Type.Optional(Type.Boolean()) }, + { + expression: Type.String(), + returnByValue: Type.Optional(Type.Boolean()), + awaitPromise: Type.Optional(Type.Boolean()), + userGesture: Type.Optional(Type.Boolean()), + }, { additionalProperties: true }, ), Type.Object({ result: RemoteObject, exceptionDetails: Type.Optional(ExceptionDetails) }), |
