From 8df1639048529b383358000879b5ee078a90b9f9 Mon Sep 17 00:00:00 2001
From: Ogulcan Celik <ogulcancelik@gmail.com>
Date: Sat, 30 May 2026 01:53:55 +0300
Subject: fix: use login shells for macos panes

refs #350
---
 src/workspace/tab.rs | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

(limited to 'src/workspace/tab.rs')

diff --git a/src/workspace/tab.rs b/src/workspace/tab.rs
index 100e67d0..f3ad594e 100644
--- a/src/workspace/tab.rs
+++ b/src/workspace/tab.rs
@@ -53,7 +53,7 @@ impl Tab {
         cols: u16,
         scrollback_limit_bytes: usize,
         host_terminal_theme: crate::terminal_theme::TerminalTheme,
-        default_shell: &str,
+        shell_config: crate::pane::PaneShellConfig<'_>,
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
@@ -65,7 +65,7 @@ impl Tab {
             cols,
             scrollback_limit_bytes,
             host_terminal_theme,
-            default_shell,
+            shell_config,
             events,
             render_notify,
             render_dirty,
@@ -92,7 +92,7 @@ impl Tab {
             cols,
             scrollback_limit_bytes,
             host_terminal_theme,
-            "",
+            crate::pane::PaneShellConfig::new("", crate::config::ShellModeConfig::NonLogin),
             events,
             render_notify,
             render_dirty,
@@ -108,7 +108,7 @@ impl Tab {
         cols: u16,
         scrollback_limit_bytes: usize,
         host_terminal_theme: crate::terminal_theme::TerminalTheme,
-        default_shell: &str,
+        shell_config: crate::pane::PaneShellConfig<'_>,
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
@@ -136,7 +136,7 @@ impl Tab {
                 initial_cwd.clone(),
                 scrollback_limit_bytes,
                 host_terminal_theme,
-                default_shell,
+                shell_config,
                 events.clone(),
                 render_notify.clone(),
                 render_dirty.clone(),
@@ -194,7 +194,7 @@ impl Tab {
         cwd: Option<PathBuf>,
         scrollback_limit_bytes: usize,
         host_terminal_theme: crate::terminal_theme::TerminalTheme,
-        default_shell: &str,
+        shell_config: crate::pane::PaneShellConfig<'_>,
     ) -> std::io::Result<NewPane> {
         self.split_focused_with_runtime(
             direction,
@@ -203,7 +203,7 @@ impl Tab {
             cwd,
             scrollback_limit_bytes,
             host_terminal_theme,
-            default_shell,
+            shell_config,
             None,
         )
     }
@@ -226,7 +226,7 @@ impl Tab {
             cwd,
             scrollback_limit_bytes,
             host_terminal_theme,
-            "",
+            crate::pane::PaneShellConfig::new("", crate::config::ShellModeConfig::NonLogin),
             Some(SplitCommand::Shell { command, extra_env }),
         )
     }
@@ -248,7 +248,7 @@ impl Tab {
             cwd,
             scrollback_limit_bytes,
             host_terminal_theme,
-            "",
+            crate::pane::PaneShellConfig::new("", crate::config::ShellModeConfig::NonLogin),
             Some(SplitCommand::Argv { argv }),
         )
     }
@@ -261,7 +261,7 @@ impl Tab {
         cwd: Option<PathBuf>,
         scrollback_limit_bytes: usize,
         host_terminal_theme: crate::terminal_theme::TerminalTheme,
-        default_shell: &str,
+        shell_config: crate::pane::PaneShellConfig<'_>,
         command: Option<SplitCommand<'_>>,
     ) -> std::io::Result<NewPane> {
         let previous_focus = self.layout.focused();
@@ -308,7 +308,7 @@ impl Tab {
                 actual_cwd.clone(),
                 scrollback_limit_bytes,
                 host_terminal_theme,
-                default_shell,
+                shell_config,
                 self.events.clone(),
                 self.render_notify.clone(),
                 self.render_dirty.clone(),
-- 
cgit v1.2.3