From f76d7df549e95e1699651f59916e9a38f0f58985 Mon Sep 17 00:00:00 2001 From: Michael Hackner Date: Thu, 13 Aug 2026 08:00:32 -0700 Subject: fix: keep tab and sidebar clicks when the terminal reports a stray drag (#2736) * fix: keep tab and sidebar clicks when the terminal reports a stray drag This works around a Ghostty bug that causes herdr tabs to be unclickable in fullscreen mode. Ghostty on macOS in native fullscreen emits one motion report after a fresh press in the strip where the menu bar reveals, with the row shifted to near the bottom of the grid. The cause is upstream: macOS delivers one mouse event whose y is nearly a window height away from the real pointer, and Ghostty reports it as it arrives (iTerm2 and Terminal.app report the same clicks correctly). Herdr treated the stray report as a real drag and lost the click two ways: it opened a tab reorder with no drop target, making the release a no-op, and it handed the release to the pane under the bogus coordinates. Now, a press on the tab bar or sidebar owns the gesture until release, and a tab drag only starts once the pointer is over a real drop target. refs #796 * fix: scope chrome mouse gestures to their input source * fix: preserve chrome drag input source * fix: preserve concurrent chrome presses --------- Co-authored-by: Ogulcan Celik --- src/ui/sidebar.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'src/ui/sidebar.rs') diff --git a/src/ui/sidebar.rs b/src/ui/sidebar.rs index c6533880..bc294cfe 100644 --- a/src/ui/sidebar.rs +++ b/src/ui/sidebar.rs @@ -2748,6 +2748,7 @@ rows = [[{ token = "git_status", fg = "#123456" }]] assert_eq!(indicator_row, app.view.workspace_card_areas[1].rect.y); app.drag = Some(crate::app::state::DragState { target: crate::app::state::DragTarget::WorkspaceReorder { + source_id: 0, source_ws_idx: 0, drop_target: Some(crate::app::state::WorkspaceDropTarget::Before(2)), }, -- cgit v1.2.3