From f7a7da03fc27cc6fe4e6a44dabddcd303f939bb9 Mon Sep 17 00:00:00 2001
From: Ogulcan Celik <ogulcancelik@gmail.com>
Date: Fri, 12 Jun 2026 19:07:07 +0300
Subject: fix: stabilize public pane and tab ids

refs #569
---
 src/terminal/runtime.rs | 12 ++++++++++++
 1 file changed, 12 insertions(+)

(limited to 'src/terminal')

diff --git a/src/terminal/runtime.rs b/src/terminal/runtime.rs
index ec830833..c4bf91e1 100644
--- a/src/terminal/runtime.rs
+++ b/src/terminal/runtime.rs
@@ -88,6 +88,7 @@ impl TerminalRuntime {
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
+        public_pane_id: Option<&str>,
     ) -> std::io::Result<Self> {
         crate::pane::PaneRuntime::spawn(
             pane_id,
@@ -100,10 +101,13 @@ impl TerminalRuntime {
             events,
             render_notify,
             render_dirty,
+            public_pane_id,
         )
         .map(Self)
     }
 
+    // Wrapper mirrors pane runtime construction arguments.
+    #[allow(clippy::too_many_arguments)]
     pub fn spawn_with_initial_history(
         pane_id: PaneId,
         rows: u16,
@@ -116,6 +120,7 @@ impl TerminalRuntime {
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
+        public_pane_id: Option<&str>,
     ) -> std::io::Result<Self> {
         crate::pane::PaneRuntime::spawn_with_initial_history(
             pane_id,
@@ -129,10 +134,13 @@ impl TerminalRuntime {
             events,
             render_notify,
             render_dirty,
+            public_pane_id,
         )
         .map(Self)
     }
 
+    // Wrapper mirrors pane runtime construction arguments.
+    #[allow(clippy::too_many_arguments)]
     pub fn spawn_shell_command(
         pane_id: PaneId,
         rows: u16,
@@ -145,6 +153,7 @@ impl TerminalRuntime {
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
+        public_pane_id: Option<&str>,
     ) -> std::io::Result<Self> {
         crate::pane::PaneRuntime::spawn_shell_command(
             pane_id,
@@ -158,6 +167,7 @@ impl TerminalRuntime {
             events,
             render_notify,
             render_dirty,
+            public_pane_id,
         )
         .map(Self)
     }
@@ -173,6 +183,7 @@ impl TerminalRuntime {
         events: mpsc::Sender<AppEvent>,
         render_notify: Arc<Notify>,
         render_dirty: Arc<AtomicBool>,
+        public_pane_id: Option<&str>,
     ) -> std::io::Result<Self> {
         crate::pane::PaneRuntime::spawn_argv_command(
             pane_id,
@@ -185,6 +196,7 @@ impl TerminalRuntime {
             events,
             render_notify,
             render_dirty,
+            public_pane_id,
         )
         .map(Self)
     }
-- 
cgit v1.2.3