From 207be3c771d281baae6e5fa0fb74be9a056e97a2 Mon Sep 17 00:00:00 2001 From: Can Celik Date: Tue, 1 Sep 2026 15:48:22 +0300 Subject: refactor: render the shell in the client (#3487) * feat: add opt-in client-rendered shell * feat: add client-owned shell mouse controls * feat: complete client-owned shell chrome * feat: add client-owned shell settings and notifications * feat: run client shell custom commands * feat: render popup terminals in client shell * feat: add client-owned scrollback and copy mode * fix: preserve client worktree trust defaults * feat: render startup diagnostics in client shell * feat: render onboarding in client shell * feat: render product announcements in client shell * feat: render release notes in client shell * feat: render mobile switcher in client shell * feat: render kitty graphics in client shell * fix: preserve client shell lifecycle coherence * refactor: route client shell commands through endpoint connections * refactor: make the client-rendered shell the default * refactor: remove monolithic launch mode * refactor: complete client-rendered shell cutover * perf: retain client pane surface updates * perf: scale retained pane surface updates * perf: remove remote pane input latency * test: make client shell checks platform-independent * fix: prevent client timer starvation * test: fix client shell platform gates * test: accept retained surfaces in cross-area checks * test: make client mode assertions platform-neutral * fix: badge only outdated integrations --- src/server/autodetect.rs | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) (limited to 'src/server/autodetect.rs') diff --git a/src/server/autodetect.rs b/src/server/autodetect.rs index 337c388f..1813ebd9 100644 --- a/src/server/autodetect.rs +++ b/src/server/autodetect.rs @@ -3,10 +3,7 @@ //! When the user runs `herdr` with no subcommand: //! 1. Check if a server is already listening on the client socket //! 2. If no server → spawn one as a background daemon → wait for socket readiness (up to 15s) -//! 3. Attach as a thin client to the server -//! -//! The `--no-session` flag bypasses server/client entirely and runs monolithically -//! (escape hatch for users who want the traditional single-process behavior). +//! 3. Attach as a client to the server use std::io; use std::path::Path; @@ -66,7 +63,7 @@ fn is_server_listening_at(socket_path: &Path) -> bool { Ok(_) => { // Server is listening. Close the test connection immediately. // The server's handshake handler will time out on this connection - // since we don't send Hello, which is fine. + // since we don't send a handshake, which is fine. true } Err(err) @@ -117,15 +114,13 @@ fn client_protocol_accepts_hello(socket_path: &Path) -> io::Result { Err(err) => return Err(err), }; - let hello = crate::protocol::ClientMessage::Hello { + let hello = crate::protocol::ClientMessage::TerminalHello { version: crate::protocol::PROTOCOL_VERSION, cols: 80, rows: 24, cell_width_px: 0, cell_height_px: 0, - requested_encoding: crate::protocol::RenderEncoding::SemanticFrame, - keybindings: crate::protocol::ClientKeybindings::Server, - launch_mode: crate::protocol::ClientLaunchMode::App, + pixel_mouse: false, }; match crate::protocol::write_message(&mut stream, &hello) { @@ -281,7 +276,7 @@ pub fn wait_for_server_socket(socket_path: &Path, timeout: Duration) -> io::Resu /// attach as a thin client. /// /// This is the entry point called from `main.rs` when the user runs `herdr` -/// without `--no-session` and without a subcommand. +/// without a subcommand. /// /// Flow: /// 1. Check if a server is listening on the client socket -- cgit v1.2.3