From fc99070a22aca3403828fc72907d5b05798fb4ff Mon Sep 17 00:00:00 2001 From: Ogulcan Celik Date: Thu, 16 Apr 2026 21:47:09 +0300 Subject: fix: only preview newer saved release notes --- src/release_notes.rs | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) (limited to 'src/release_notes.rs') diff --git a/src/release_notes.rs b/src/release_notes.rs index 7d83dd15..dd09aaf8 100644 --- a/src/release_notes.rs +++ b/src/release_notes.rs @@ -100,8 +100,16 @@ fn release_notes_from_stored( return None; } + let preview = match ( + crate::update::Version::parse(&stored.version), + crate::update::Version::parse(current_version), + ) { + (Some(stored_version), Some(current_version)) => stored_version > current_version, + _ => false, + }; + Some(ReleaseNotes { - preview: stored.version != current_version, + preview, version: stored.version, body, }) @@ -213,6 +221,24 @@ mod tests { clear_pending_at(&path).unwrap(); } + #[test] + fn load_latest_does_not_mark_older_saved_version_as_preview() { + let path = std::env::temp_dir().join(format!( + "herdr-release-notes-{}-{}.json", + std::process::id(), + "stale" + )); + let _ = clear_pending_at(&path); + save_pending_to_path(&path, "0.3.0", "### Changed\n- One").unwrap(); + + let notes = load_latest_from_path(&path, "0.3.1").expect("latest notes"); + assert_eq!(notes.version, "0.3.0"); + assert_eq!(notes.body, "### Changed\n- One"); + assert!(!notes.preview); + + clear_pending_at(&path).unwrap(); + } + #[test] fn marking_current_version_seen_preserves_latest_notes_without_startup_modal() { let path = std::env::temp_dir().join(format!( -- cgit v1.2.3