From 482818130407691154d1635d4029b95d0e730104 Mon Sep 17 00:00:00 2001 From: "Rudolf S." Date: Mon, 7 Sep 2026 14:04:54 +0200 Subject: feat: make ui.pane_borders a three-state auto/always/off mode (#3234) * feat: make ui.pane_borders a three-state auto/always/off mode Legacy booleans keep parsing (true = auto, false = off); "always" frames a lone pane while pane_outer_borders is enabled. * fix: align pane border reload test and documentation --------- Co-authored-by: Rudolf Schmidt Co-authored-by: Jonathan Liebig --- src/app/agent_resume.rs | 2 +- src/app/mod.rs | 10 +++------- src/app/state.rs | 4 ++-- 3 files changed, 6 insertions(+), 10 deletions(-) (limited to 'src/app') diff --git a/src/app/agent_resume.rs b/src/app/agent_resume.rs index 4bc12c24..2cbd93ab 100644 --- a/src/app/agent_resume.rs +++ b/src/app/agent_resume.rs @@ -289,7 +289,7 @@ impl App { fn derived_pending_agent_resume_pane_infos( tab: &crate::workspace::Tab, terminal_area: Rect, - pane_borders: bool, + pane_borders: crate::config::PaneBordersConfig, pane_gaps: bool, pane_outer_borders: bool, ) -> Vec { diff --git a/src/app/mod.rs b/src/app/mod.rs index 110be9b7..a0b90023 100644 --- a/src/app/mod.rs +++ b/src/app/mod.rs @@ -1874,13 +1874,9 @@ mod tests { let original_pane_borders = app.state.pane_borders; // Pair the bad bounds with another `[ui]` field change to confirm the // entire section is treated as invalid (not just the bounds). - let target_pane_borders = !original_pane_borders; std::fs::write( &path, - format!( - "[ui]\nsidebar_min_width = 50\nsidebar_max_width = 30\npane_borders = {}\n", - target_pane_borders - ), + "[ui]\nsidebar_min_width = 50\nsidebar_max_width = 30\npane_borders = \"always\"\n", ) .unwrap(); @@ -1945,10 +1941,10 @@ mod tests { std::env::set_var(crate::config::CONFIG_PATH_ENV_VAR, &path); let mut app = test_app(); - let target_pane_borders = !app.state.pane_borders; + let target_pane_borders = crate::config::PaneBordersConfig::Always; std::fs::write( &path, - format!("[ui]\npane_borders = {target_pane_borders}\nmouse_captur = false\n"), + "[ui]\npane_borders = \"always\"\nmouse_captur = false\n", ) .unwrap(); diff --git a/src/app/state.rs b/src/app/state.rs index 3d3700b2..892ec5e9 100644 --- a/src/app/state.rs +++ b/src/app/state.rs @@ -831,7 +831,7 @@ pub struct AppState { pub sidebar_spaces: crate::config::SpacesSidebarConfig, pub next_agent_state_change_seq: u64, pub confirm_close: bool, - pub pane_borders: bool, + pub pane_borders: crate::config::PaneBordersConfig, pub pane_outer_borders: bool, pub pane_scrollbars: bool, pub pane_gaps: bool, @@ -1058,7 +1058,7 @@ impl AppState { sidebar_spaces: crate::config::SpacesSidebarConfig::default(), next_agent_state_change_seq: 0, confirm_close: true, - pane_borders: true, + pane_borders: crate::config::PaneBordersConfig::Auto, pane_outer_borders: true, pane_scrollbars: true, pane_gaps: false, -- cgit v1.2.3