From f76d7df549e95e1699651f59916e9a38f0f58985 Mon Sep 17 00:00:00 2001 From: Michael Hackner Date: Thu, 13 Aug 2026 08:00:32 -0700 Subject: fix: keep tab and sidebar clicks when the terminal reports a stray drag (#2736) * fix: keep tab and sidebar clicks when the terminal reports a stray drag This works around a Ghostty bug that causes herdr tabs to be unclickable in fullscreen mode. Ghostty on macOS in native fullscreen emits one motion report after a fresh press in the strip where the menu bar reveals, with the row shifted to near the bottom of the grid. The cause is upstream: macOS delivers one mouse event whose y is nearly a window height away from the real pointer, and Ghostty reports it as it arrives (iTerm2 and Terminal.app report the same clicks correctly). Herdr treated the stray report as a real drag and lost the click two ways: it opened a tab reorder with no drop target, making the release a no-op, and it handed the release to the pane under the bogus coordinates. Now, a press on the tab bar or sidebar owns the gesture until release, and a tab drag only starts once the pointer is over a real drop target. refs #796 * fix: scope chrome mouse gestures to their input source * fix: preserve chrome drag input source * fix: preserve concurrent chrome presses --------- Co-authored-by: Ogulcan Celik --- src/app/input/mod.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/app/input/mod.rs') diff --git a/src/app/input/mod.rs b/src/app/input/mod.rs index 3202ae26..45124107 100644 --- a/src/app/input/mod.rs +++ b/src/app/input/mod.rs @@ -392,7 +392,10 @@ impl App { let previous_agent_panel_sort = self.state.agent_panel_sort; let previous_settings_section = self.state.settings.section; if !handled_pane_double_click { - if let Some(action) = self.state.handle_mouse(&mut self.terminal_runtimes, mouse) { + if let Some(action) = + self.state + .handle_mouse(&mut self.terminal_runtimes, source_id, mouse) + { match action { MouseAction::NewWorkspace => { self.begin_tui_workspace_create("tui.mouse.workspace.create") -- cgit v1.2.3