From f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 01:19:58 +0530 Subject: refactor: close the remaining unguarded type assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Types the event-queue iterator's TReturn as undefined so the terminal result needs no cast; declares the isError field the pi runtime reads by duck-typing; binds socket to a local const in the daemon transport; replaces the @ts-ignore on the optional sharp import with a non-literal specifier so src/ still typechecks where sharp was not installed. Adds src/util/guards.ts as the single home for narrowing over unknown — isRecord plus scalar/array readers — and converts the two private isObject copies in cdp/types.ts and daemon/protocol.ts along with every inline `as Record` in domains/js.ts and domains/render.ts. Gives Accessibility.getFullAXTree a real result schema, closing the last unvalidated CDP boundary: only nodeId is required, every object carries additionalProperties, and each AX value stays Unknown, so the tree decodes as a whole or fails as a whole rather than being filtered. Guards the five tool-result `details` readers, the daemon attach response, the persisted session state, the browser-namespace flag, and the fs errno narrowing, each feeding an already-present failure path. The daemon-transport socket binding is not a bug fix: send() runs synchronously inside sendWithTimeout's promise executor, so socket cannot be reassigned between the check and the write. It removes the assertion and makes the write immune to a later refactor that adds an await. Two assertions survive by design and are documented in the task report: the never->unknown re-widening in util/tool.ts, which the type-erased tool registry makes unavoidable, and the AsyncFunction constructor lookup in domains/js.ts, which JavaScript exposes no typed binding for. Co-Authored-By: Claude Opus 5 (1M context) --- src/domains/screenshot.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/domains/screenshot.ts') diff --git a/src/domains/screenshot.ts b/src/domains/screenshot.ts index c6cc87b..2e9cfdc 100644 --- a/src/domains/screenshot.ts +++ b/src/domains/screenshot.ts @@ -7,6 +7,7 @@ import { type Result, ok } from "../util/result"; import { defineBrowserTool, type ToolErr, type ToolOk } from "../util/tool"; import { screenshotPath } from "../util/paths"; import { loadSharp } from "../util/sharp-shim"; +import { asRecord, asString } from "../util/guards"; import { safeJs } from "../util/js-template"; import { cdpCall } from "./cdp-call"; @@ -91,15 +92,16 @@ export const screenshotTool = defineBrowserTool({ }, renderResult(result, _expanded, theme) { - const details = result.details as { path?: string; format?: string } | undefined; - const filePath = details?.path; + const raw = asRecord(result.details); + const filePath = raw === undefined ? undefined : asString(raw["path"]); if (!filePath) { return new Text(theme.fg("error", "Screenshot path missing"), 0, 0); } + const format = raw === undefined ? undefined : asString(raw["format"]); try { const buf = readFileSync(filePath); const b64 = buf.toString("base64"); - const mimeType = details?.format === "jpeg" ? "image/jpeg" : "image/png"; + const mimeType = format === "jpeg" ? "image/jpeg" : "image/png"; const imageTheme: ImageTheme = { fallbackColor: (str: string) => theme.fg("dim", str), }; -- cgit v1.2.3