From f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 01:19:58 +0530 Subject: refactor: close the remaining unguarded type assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Types the event-queue iterator's TReturn as undefined so the terminal result needs no cast; declares the isError field the pi runtime reads by duck-typing; binds socket to a local const in the daemon transport; replaces the @ts-ignore on the optional sharp import with a non-literal specifier so src/ still typechecks where sharp was not installed. Adds src/util/guards.ts as the single home for narrowing over unknown — isRecord plus scalar/array readers — and converts the two private isObject copies in cdp/types.ts and daemon/protocol.ts along with every inline `as Record` in domains/js.ts and domains/render.ts. Gives Accessibility.getFullAXTree a real result schema, closing the last unvalidated CDP boundary: only nodeId is required, every object carries additionalProperties, and each AX value stays Unknown, so the tree decodes as a whole or fails as a whole rather than being filtered. Guards the five tool-result `details` readers, the daemon attach response, the persisted session state, the browser-namespace flag, and the fs errno narrowing, each feeding an already-present failure path. The daemon-transport socket binding is not a bug fix: send() runs synchronously inside sendWithTimeout's promise executor, so socket cannot be reassigned between the check and the write. It removes the assertion and makes the write immune to a later refactor that adds an await. Two assertions survive by design and are documented in the task report: the never->unknown re-widening in util/tool.ts, which the type-erased tool registry makes unavoidable, and the AsyncFunction constructor lookup in domains/js.ts, which JavaScript exposes no typed binding for. Co-Authored-By: Claude Opus 5 (1M context) --- src/domains/render.ts | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'src/domains/render.ts') diff --git a/src/domains/render.ts b/src/domains/render.ts index f6a6535..1e4e30d 100644 --- a/src/domains/render.ts +++ b/src/domains/render.ts @@ -11,6 +11,7 @@ import { Markdown, Text } from "@mariozechner/pi-tui"; import { getMarkdownTheme, keyHint } from "@mariozechner/pi-coding-agent"; import type { Component } from "@mariozechner/pi-tui"; import type { Theme } from "@mariozechner/pi-coding-agent"; +import { isRecord } from "../util/guards"; const COMPACT_PREVIEW_LINES = 6; @@ -24,16 +25,11 @@ export type ExpandableText = { readonly fullOutputPath?: string; }; -const isExpandableText = (value: unknown): value is ExpandableText => { - if (typeof value !== "object" || value === null) return false; - const v = value as Record; - return typeof v["summary"] === "string" && typeof v["body"] === "string"; -}; +const isExpandableText = (value: unknown): value is ExpandableText => + isRecord(value) && typeof value["summary"] === "string" && typeof value["body"] === "string"; -const extractRender = (details: unknown): unknown => { - if (typeof details !== "object" || details === null) return undefined; - return (details as Record)["render"]; -}; +const extractRender = (details: unknown): unknown => + isRecord(details) ? details["render"] : undefined; /** * Build a renderResult over an ExpandableText stored in `details.render`. -- cgit v1.2.3