From f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 01:19:58 +0530 Subject: refactor: close the remaining unguarded type assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Types the event-queue iterator's TReturn as undefined so the terminal result needs no cast; declares the isError field the pi runtime reads by duck-typing; binds socket to a local const in the daemon transport; replaces the @ts-ignore on the optional sharp import with a non-literal specifier so src/ still typechecks where sharp was not installed. Adds src/util/guards.ts as the single home for narrowing over unknown — isRecord plus scalar/array readers — and converts the two private isObject copies in cdp/types.ts and daemon/protocol.ts along with every inline `as Record` in domains/js.ts and domains/render.ts. Gives Accessibility.getFullAXTree a real result schema, closing the last unvalidated CDP boundary: only nodeId is required, every object carries additionalProperties, and each AX value stays Unknown, so the tree decodes as a whole or fails as a whole rather than being filtered. Guards the five tool-result `details` readers, the daemon attach response, the persisted session state, the browser-namespace flag, and the fs errno narrowing, each feeding an already-present failure path. The daemon-transport socket binding is not a bug fix: send() runs synchronously inside sendWithTimeout's promise executor, so socket cannot be reassigned between the check and the write. It removes the assertion and makes the write immune to a later refactor that adds an await. Two assertions survive by design and are documented in the task report: the never->unknown re-widening in util/tool.ts, which the type-erased tool registry makes unavoidable, and the AsyncFunction constructor lookup in domains/js.ts, which JavaScript exposes no typed binding for. Co-Authored-By: Claude Opus 5 (1M context) --- src/domains/network.ts | 54 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-) (limited to 'src/domains/network.ts') diff --git a/src/domains/network.ts b/src/domains/network.ts index dc23c6d..fa755b3 100644 --- a/src/domains/network.ts +++ b/src/domains/network.ts @@ -4,6 +4,7 @@ import { getMarkdownTheme, keyHint } from "@mariozechner/pi-coding-agent"; import { type Result, err, ok } from "../util/result"; import { defineBrowserTool, type ToolErr, type ToolOk } from "../util/tool"; import { applyTruncation } from "../util/truncate"; +import { asArrayOf, asBoolean, asNumber, asRecord, asString } from "../util/guards"; import type { NetworkRecord } from "../cdp/network-buffer"; const HttpGetArgs = Type.Object({ @@ -168,6 +169,57 @@ type NetworkDetails = { includeBodies: boolean; }; +const asNetworkRecord = (v: unknown): NetworkRecord | undefined => { + const o = asRecord(v); + if (o === undefined) return undefined; + const method = asString(o["method"]); + const url = asString(o["url"]); + const type = asString(o["type"]); + if (method === undefined || url === undefined || type === undefined) return undefined; + const status = asNumber(o["status"]); + const statusText = asString(o["statusText"]); + const mimeType = asString(o["mimeType"]); + const durationMs = asNumber(o["durationMs"]); + const responseBodySize = asNumber(o["responseBodySize"]); + const failed = asBoolean(o["failed"]); + const errorText = asString(o["errorText"]); + const bodyRaw = o["body"]; + const body = typeof bodyRaw === "string" || bodyRaw === null ? bodyRaw : undefined; + return { + requestId: asString(o["requestId"]) ?? "", + method, + url, + type, + requestStartedMs: asNumber(o["requestStartedMs"]) ?? 0, + requestBodySize: asNumber(o["requestBodySize"]) ?? 0, + ...(status !== undefined ? { status } : {}), + ...(statusText !== undefined ? { statusText } : {}), + ...(mimeType !== undefined ? { mimeType } : {}), + ...(durationMs !== undefined ? { durationMs } : {}), + ...(responseBodySize !== undefined ? { responseBodySize } : {}), + ...(failed !== undefined ? { failed } : {}), + ...(errorText !== undefined ? { errorText } : {}), + ...(body !== undefined ? { body } : {}), + }; +}; + +const asNetworkDetails = (v: unknown): NetworkDetails | undefined => { + const o = asRecord(v); + if (o === undefined) return undefined; + const requests = asArrayOf(o["requests"], asNetworkRecord); + if (requests === undefined) return undefined; + const fullOutputPath = asString(o["fullOutputPath"]); + return { + total: asNumber(o["total"]) ?? requests.length, + returned: asNumber(o["returned"]) ?? requests.length, + bufferOverflowed: asBoolean(o["bufferOverflowed"]) ?? false, + truncated: asBoolean(o["truncated"]) ?? false, + requests, + includeBodies: asBoolean(o["includeBodies"]) ?? false, + ...(fullOutputPath !== undefined ? { fullOutputPath } : {}), + }; +}; + export const networkRequestsTool = defineBrowserTool({ name: "browser_network_requests", label: "Browser Network Requests", @@ -235,7 +287,7 @@ export const networkRequestsTool = defineBrowserTool({ }, renderResult(result, expanded, theme) { - const details = result.details as NetworkDetails | undefined; + const details = asNetworkDetails(result.details); if (!details) return new Text(theme.fg("error", "network: no details"), 0, 0); const md = renderNetworkMarkdown(details.requests, { -- cgit v1.2.3