From 5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 00:01:32 +0530 Subject: refactor(tools): declare concurrency in the tool definition serialized: true was applied in registry.ts, away from the tools it describes. Now a required concurrency field on each definition, with a test pinning the serialized set so the classes cannot drift. The lock check defaults to taking the mutex for any class that is not explicitly "parallel", so a definition that bypasses defineBrowserTool at runtime fails safe rather than racing on shared CDP state. The test script gains --conditions=import: pi-coding-agent publishes no "require" condition, so importing any tool definition from a CJS-loaded test could not resolve it. Co-Authored-By: Claude Opus 5 (1M context) --- src/domains/keyboard.ts | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/domains/keyboard.ts') diff --git a/src/domains/keyboard.ts b/src/domains/keyboard.ts index 6722ffb..473f633 100644 --- a/src/domains/keyboard.ts +++ b/src/domains/keyboard.ts @@ -26,6 +26,7 @@ export const typeTool = defineBrowserTool({ "For special keys (Enter, Tab, Escape, arrows), use browser_press_key instead.", ], parameters: TypeArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { const focused = await client.evaluateJs(safeJs` (() => { @@ -79,6 +80,7 @@ export const pressKeyTool = defineBrowserTool({ "Modifiers: 1=Alt, 2=Ctrl, 4=Meta(Cmd), 8=Shift. Combine with bitwise OR: Ctrl+Shift = 2|8 = 10.", ], parameters: PressKeyArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { const k = args.key; const code = virtualKeyCode(k); @@ -136,6 +138,7 @@ export const dispatchKeyTool = defineBrowserTool({ "eventType defaults to 'keydown'.", ], parameters: DispatchKeyArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { const eventType = args.eventType ?? "keydown"; const target = args.ref ?? args.selector ?? ""; -- cgit v1.2.3