From 5cfa7ccc8f4082db111bc0186c5fa3d44b767ad3 Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 00:01:32 +0530 Subject: refactor(tools): declare concurrency in the tool definition serialized: true was applied in registry.ts, away from the tools it describes. Now a required concurrency field on each definition, with a test pinning the serialized set so the classes cannot drift. The lock check defaults to taking the mutex for any class that is not explicitly "parallel", so a definition that bypasses defineBrowserTool at runtime fails safe rather than racing on shared CDP state. The test script gains --conditions=import: pi-coding-agent publishes no "require" condition, so importing any tool definition from a CJS-loaded test could not resolve it. Co-Authored-By: Claude Opus 5 (1M context) --- src/domains/form.ts | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/domains/form.ts') diff --git a/src/domains/form.ts b/src/domains/form.ts index 95516c5..6e3285a 100644 --- a/src/domains/form.ts +++ b/src/domains/form.ts @@ -136,6 +136,7 @@ export const fillTool = defineBrowserTool({ "The result reports the field's value after writing and an appended page-changes diff — confirm both match what you intended before moving on.", ], parameters: FillArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { const r = await runOnElement(client, { ref: args.ref, selector: args.selector, fnBody: FILL_FN, arg: args.value }); if (!r.success) return r; @@ -198,6 +199,7 @@ export const focusTool = defineBrowserTool({ "For simply setting a value, prefer browser_fill (it doesn't need a separate focus step).", ], parameters: FocusArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { const r = await runOnElement(client, { ref: args.ref, selector: args.selector, fnBody: FOCUS_FN, arg: "" }); if (!r.success) return r; @@ -277,6 +279,7 @@ export const selectOptionTool = defineBrowserTool({ "If no option matches, the error details list the available options so you can retry.", ], parameters: SelectOptionArgs, + concurrency: "serialized", async handler(args, { client }): Promise> { if (args.value === undefined && args.label === undefined && args.index === undefined) { return err({ kind: "invalid_state", message: "Provide one of value, label, or index." }); -- cgit v1.2.3