From f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 01:19:58 +0530 Subject: refactor: close the remaining unguarded type assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Types the event-queue iterator's TReturn as undefined so the terminal result needs no cast; declares the isError field the pi runtime reads by duck-typing; binds socket to a local const in the daemon transport; replaces the @ts-ignore on the optional sharp import with a non-literal specifier so src/ still typechecks where sharp was not installed. Adds src/util/guards.ts as the single home for narrowing over unknown — isRecord plus scalar/array readers — and converts the two private isObject copies in cdp/types.ts and daemon/protocol.ts along with every inline `as Record` in domains/js.ts and domains/render.ts. Gives Accessibility.getFullAXTree a real result schema, closing the last unvalidated CDP boundary: only nodeId is required, every object carries additionalProperties, and each AX value stays Unknown, so the tree decodes as a whole or fails as a whole rather than being filtered. Guards the five tool-result `details` readers, the daemon attach response, the persisted session state, the browser-namespace flag, and the fs errno narrowing, each feeding an already-present failure path. The daemon-transport socket binding is not a bug fix: send() runs synchronously inside sendWithTimeout's promise executor, so socket cannot be reassigned between the check and the write. It removes the assertion and makes the write immune to a later refactor that adds an await. Two assertions survive by design and are documented in the task report: the never->unknown re-widening in util/tool.ts, which the type-erased tool registry makes unavoidable, and the AsyncFunction constructor lookup in domains/js.ts, which JavaScript exposes no typed binding for. Co-Authored-By: Claude Opus 5 (1M context) --- src/cdp/event-queue.ts | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'src/cdp/event-queue.ts') diff --git a/src/cdp/event-queue.ts b/src/cdp/event-queue.ts index 281fb3f..87f5551 100644 --- a/src/cdp/event-queue.ts +++ b/src/cdp/event-queue.ts @@ -30,7 +30,7 @@ export type EventQueue = { export const makeEventQueue = (): EventQueue => { const buf: CdpEvent[] = []; - const waiters: Array<(v: IteratorResult) => void> = []; + const waiters: Array<(v: IteratorResult) => void> = []; let ended = false; return { push(e) { @@ -41,19 +41,16 @@ export const makeEventQueue = (): EventQueue => { }, end() { ended = true; - // value: undefined as unknown as CdpEvent is the correct iterator-protocol - // pattern: when done=true the value field is conventionally undefined but - // the TS type still requires CdpEvent. - for (const w of waiters.splice(0)) w({ value: undefined as unknown as CdpEvent, done: true }); + for (const w of waiters.splice(0)) w({ value: undefined, done: true }); }, iter: { - [Symbol.asyncIterator]() { + [Symbol.asyncIterator](): AsyncIterator { return { - next: (): Promise> => + next: (): Promise> => new Promise((resolve) => { const next = buf.shift(); if (next) resolve({ value: next, done: false }); - else if (ended) resolve({ value: undefined as unknown as CdpEvent, done: true }); + else if (ended) resolve({ value: undefined, done: true }); else waiters.push(resolve); }), }; -- cgit v1.2.3