From f9dcdf7f6dcdf2979693a9f179eda2b9995d57ae Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 01:19:58 +0530 Subject: refactor: close the remaining unguarded type assertions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Types the event-queue iterator's TReturn as undefined so the terminal result needs no cast; declares the isError field the pi runtime reads by duck-typing; binds socket to a local const in the daemon transport; replaces the @ts-ignore on the optional sharp import with a non-literal specifier so src/ still typechecks where sharp was not installed. Adds src/util/guards.ts as the single home for narrowing over unknown — isRecord plus scalar/array readers — and converts the two private isObject copies in cdp/types.ts and daemon/protocol.ts along with every inline `as Record` in domains/js.ts and domains/render.ts. Gives Accessibility.getFullAXTree a real result schema, closing the last unvalidated CDP boundary: only nodeId is required, every object carries additionalProperties, and each AX value stays Unknown, so the tree decodes as a whole or fails as a whole rather than being filtered. Guards the five tool-result `details` readers, the daemon attach response, the persisted session state, the browser-namespace flag, and the fs errno narrowing, each feeding an already-present failure path. The daemon-transport socket binding is not a bug fix: send() runs synchronously inside sendWithTimeout's promise executor, so socket cannot be reassigned between the check and the write. It removes the assertion and makes the write immune to a later refactor that adds an await. Two assertions survive by design and are documented in the task report: the never->unknown re-widening in util/tool.ts, which the type-erased tool registry makes unavoidable, and the AsyncFunction constructor lookup in domains/js.ts, which JavaScript exposes no typed binding for. Co-Authored-By: Claude Opus 5 (1M context) --- src/cdp/commands.ts | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) (limited to 'src/cdp/commands.ts') diff --git a/src/cdp/commands.ts b/src/cdp/commands.ts index 95c8be2..e6d744d 100644 --- a/src/cdp/commands.ts +++ b/src/cdp/commands.ts @@ -50,6 +50,33 @@ const ExceptionDetails = Type.Object( { additionalProperties: true }, ); +const AxValue = Type.Object({ value: Type.Optional(Type.Unknown()) }, { additionalProperties: true }); + +const AxNode = Type.Object( + { + nodeId: Type.String(), + parentId: Type.Optional(Type.String()), + childIds: Type.Optional(Type.Array(Type.String())), + ignored: Type.Optional(Type.Boolean()), + role: Type.Optional(AxValue), + name: Type.Optional(AxValue), + value: Type.Optional(AxValue), + description: Type.Optional(AxValue), + properties: Type.Optional( + Type.Array( + Type.Object( + { name: Type.Optional(Type.String()), value: Type.Optional(AxValue) }, + { additionalProperties: true }, + ), + ), + ), + backendDOMNodeId: Type.Optional(Type.Number()), + }, + { additionalProperties: true }, +); + +export type AxNodeResult = Static; + export const COMMANDS = { // --- Target --- "Target.attachToTarget": cmd( @@ -211,7 +238,7 @@ export const COMMANDS = { "Emulation.setDeviceMetricsOverride": cmd(Type.Object({}, { additionalProperties: true }), Empty), "Accessibility.getFullAXTree": cmd( Type.Object({ depth: Type.Optional(Type.Number()) }, { additionalProperties: true }), - Type.Object({ nodes: Type.Array(Type.Unknown()) }), + Type.Object({ nodes: Type.Array(AxNode) }), ), }; -- cgit v1.2.3