From 632600ec0a0a68d9327e19bd419a1ae72047955f Mon Sep 17 00:00:00 2001 From: amankumarsingh77 Date: Tue, 28 Jul 2026 21:55:55 +0530 Subject: refactor: one door from a tool to the browser MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Four routes coexisted: cdpCall, a raw client.session().call, a session held in a local and called directly, and client.evaluateJs — and five files mixed two or three of them. The CdpError-to-ToolErr mapping was hand-copied at nine sites, plus a private copy in isolated-tab.ts. domains/cdp-call.ts now owns all of it: cdpErrToToolErr, cdpCall, cdpCallOnTarget, cdpCallBrowser, evalJs. Every other file under src/domains goes through them, which also removes a pile of `if (!r.success) return err({ kind: "cdp_error", ... })` boilerplate in favour of returning the failed Result as-is. Two scanner rules keep it that way, scoped to src/domains/ so the layer that legitimately owns the session — cdp/ and client.ts — is unaffected. Scoping is new to the rule model; without it the rules fired on the transport itself. One deliberate behaviour change: a CDP timeout now surfaces as kind "timeout" rather than "cdp_error". isolated-tab.ts already did this and the other 13 sites flattened it; the shared mapper uses the honest label rather than preserving the mislabel. Co-Authored-By: Claude Opus 5 (1M context) --- scripts/check-boundaries.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'scripts/check-boundaries.ts') diff --git a/scripts/check-boundaries.ts b/scripts/check-boundaries.ts index c438b83..7dd97e2 100644 --- a/scripts/check-boundaries.ts +++ b/scripts/check-boundaries.ts @@ -11,7 +11,8 @@ export type Violation = { readonly text: string; }; -const RULES: ReadonlyArray<{ readonly rule: string; readonly re: RegExp }> = [ +// `scope` restricts a rule to one layer: the tool layer must go through domains/cdp-call.ts, while cdp/ and client.ts are the layer that owns the session. +const RULES: ReadonlyArray<{ readonly rule: string; readonly re: RegExp; readonly scope?: RegExp }> = [ { rule: "as-any", re: /\bas\s+any\b/ }, { rule: "ts-ignore", re: /@ts-(ignore|expect-error|nocheck)/ }, { rule: "non-null-assertion", re: /[A-Za-z_$)\]]!\s*(?:[.[(;,)\]}]|$)/ }, @@ -20,6 +21,8 @@ const RULES: ReadonlyArray<{ readonly rule: string; readonly re: RegExp }> = [ { rule: "named-cast", re: /\bas\s+(?:new\s+)?[A-Z][A-Za-z0-9_]*/ }, { rule: "function-cast", re: /\bas\s+\(/ }, { rule: "trailing-cast", re: /\bas\s*$/ }, + { rule: "raw-cdp-call", re: /(?:session\(\)|\bsession)\.call(?:OnTarget|Browser)?\(/, scope: /^src\/domains\// }, + { rule: "raw-evaluate", re: /\.evaluateJs\(/, scope: /^src\/domains\// }, ]; export type SourceFile = { readonly path: string; readonly text: string }; @@ -37,8 +40,10 @@ const budgets = (exemptions: ReadonlyArray): Map => { const rawHits = (files: ReadonlyArray): ReadonlyArray => { const out: Violation[] = []; for (const file of files) { + const path = normalise(file.path); for (const [i, line] of file.text.split("\n").entries()) { - for (const { rule, re } of RULES) { + for (const { rule, re, scope } of RULES) { + if (scope && !scope.test(path)) continue; if (re.test(line)) out.push({ path: file.path, line: i + 1, rule, text: line.trim() }); } } -- cgit v1.2.3